-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing RBAC permissions to autoscaler chart #4154
Conversation
/assign @gjtempleton |
Sorry for the delay in reviewing. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, MarcusNoble The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think the chart version here |
@stevehipwell Good catch, you're 100% correct. If you could raise that PR that would be great. I've stuck a hold on the PR to update the index.yaml for now. |
Ah yes! Good catch indeed. Looks like I made a typo when handling the merge conflict. |
I've added PR #4183. |
After a bit of digging, found why this slipped through linting. It seems both With a bit of testing in a cluster this non-compliant version will still successfully install, as it seems all of the code dealing with SemVer handles these versions in the same way. |
That's my understanding too, but other tools using |
Similar change was done in kubernetes#4154
Similar change was done in kubernetes#4154
Similar change was done in kubernetes#4154
Similar change was done in kubernetes#4154
Fixes #4114
Added RBAC permissions to watch, list and get
csidrivers
andcsistoragecapacities