Make sure node_ip is set if node is in etcd group #6719
Conversation
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
And this also needs to be backported in 2.14(.1) |
|
done in #6720 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EppO, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/close |
|
@floryut: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@floryut: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* 'master' of https://github.com/kubernetes-sigs/kubespray: (21 commits) Make sure node_ip is set if node is in etcd group (kubernetes-sigs#6719) Fix order of OS CI cleanup (kubernetes-sigs#6714) Remove vagrant.deb from docker image (kubernetes-sigs#6717) Move floruyt to approver (kubernetes-sigs#6713) Add support for periodic CI (kubernetes-sigs#6715) Ignore pause from kubeadm config images list (kubernetes-sigs#6689) Ignore error in check mode when disabling swap (kubernetes-sigs#6703) flannel image arch specific tag (kubernetes-sigs#6685) Added missing permissions for operator. (kubernetes-sigs#6683) Add Kubernetes hashes 1.19.2/1.18.9/1.17.12 and set default (kubernetes-sigs#6698) Cleanup virsh volumes in Vagrant CI (kubernetes-sigs#6688) Use "kubeadm join" to join masters to control plane (kubernetes-sigs#6661) Remove workaround with kube_proxy_remove (kubernetes-sigs#6512) fix incorrect documentation of use_access_ip (kubernetes-sigs#6674) make metallb image repos configurable (kubernetes-sigs#6671) (kubernetes-sigs#6672) fix remove node (kubernetes-sigs#6666) Allow configuration of nodelabels in local_volume_provisioner (kubernetes-sigs#6620) Add support for Calico CNI host-local IPAM plugin (kubernetes-sigs#6580) Update third party librairies and tools (kubernetes-sigs#6669) Updated KataContainers version to 1.11.3 (kubernetes-sigs#6694) ...
What type of PR is this?
/kind bug
What this PR does / why we need it:
Removal of non-etcd nodes is not possible in 2.14.0 and master at this point.
Which issue(s) this PR fixes:
Fixes #6692
Fixes #6690
Special notes for your reviewer:
CLA-friendly issue of #6692
Does this PR introduce a user-facing change?: