Ignore error in check mode when disabling swap #6703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Sep 19, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: (21 commits) Make sure node_ip is set if node is in etcd group (kubernetes-sigs#6719) Fix order of OS CI cleanup (kubernetes-sigs#6714) Remove vagrant.deb from docker image (kubernetes-sigs#6717) Move floruyt to approver (kubernetes-sigs#6713) Add support for periodic CI (kubernetes-sigs#6715) Ignore pause from kubeadm config images list (kubernetes-sigs#6689) Ignore error in check mode when disabling swap (kubernetes-sigs#6703) flannel image arch specific tag (kubernetes-sigs#6685) Added missing permissions for operator. (kubernetes-sigs#6683) Add Kubernetes hashes 1.19.2/1.18.9/1.17.12 and set default (kubernetes-sigs#6698) Cleanup virsh volumes in Vagrant CI (kubernetes-sigs#6688) Use "kubeadm join" to join masters to control plane (kubernetes-sigs#6661) Remove workaround with kube_proxy_remove (kubernetes-sigs#6512) fix incorrect documentation of use_access_ip (kubernetes-sigs#6674) make metallb image repos configurable (kubernetes-sigs#6671) (kubernetes-sigs#6672) fix remove node (kubernetes-sigs#6666) Allow configuration of nodelabels in local_volume_provisioner (kubernetes-sigs#6620) Add support for Calico CNI host-local IPAM plugin (kubernetes-sigs#6580) Update third party librairies and tools (kubernetes-sigs#6669) Updated KataContainers version to 1.11.3 (kubernetes-sigs#6694) ...
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 16, 2021
|
work has not been completed. same error in next task |
Task swapOnZram was added 5 month ago, this PR is 2 years old; so not really "work has not been completed" but more "a new task has the same issue". Please create a PR if you feel like proposing a fix, that'd very welcome |
ibonder
pushed a commit
to joomcode/kubespray
that referenced
this pull request
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Swap role fail in check mode, ignoring error when it's the case
Which issue(s) this PR fixes:
Fixes #6642
Special notes for your reviewer:
Other solution might be to always run the task
check swapin check mode, but I think this change is "cleaner"Does this PR introduce a user-facing change?: