Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of OS CI cleanup #6714

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Sep 18, 2020

What type of PR is this?
/kind flake

What this PR does / why we need it:
It is not possible to delete an OpenStack security group is a Server/VM still uses it. Therefore we should delete servers before Servers/VMs

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO September 18, 2020 08:25
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2020
@floryut
Copy link
Member

floryut commented Sep 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit e1265b2 into kubernetes-sigs:master Sep 18, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 19, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: (21 commits)
  Make sure node_ip is set if node is in etcd group (kubernetes-sigs#6719)
  Fix order of OS CI cleanup (kubernetes-sigs#6714)
  Remove vagrant.deb from docker image (kubernetes-sigs#6717)
  Move floruyt to approver (kubernetes-sigs#6713)
  Add support for periodic CI (kubernetes-sigs#6715)
  Ignore pause from kubeadm config images list (kubernetes-sigs#6689)
  Ignore error in check mode when disabling swap (kubernetes-sigs#6703)
  flannel image arch specific tag (kubernetes-sigs#6685)
  Added missing permissions for operator. (kubernetes-sigs#6683)
  Add Kubernetes hashes 1.19.2/1.18.9/1.17.12 and set default (kubernetes-sigs#6698)
  Cleanup virsh volumes in Vagrant CI (kubernetes-sigs#6688)
  Use "kubeadm join" to join masters to control plane (kubernetes-sigs#6661)
  Remove workaround with kube_proxy_remove (kubernetes-sigs#6512)
  fix incorrect documentation of use_access_ip (kubernetes-sigs#6674)
  make metallb image repos configurable (kubernetes-sigs#6671) (kubernetes-sigs#6672)
  fix remove node (kubernetes-sigs#6666)
  Allow configuration of nodelabels in local_volume_provisioner (kubernetes-sigs#6620)
  Add support for Calico CNI host-local IPAM plugin (kubernetes-sigs#6580)
  Update third party librairies and tools (kubernetes-sigs#6669)
  Updated KataContainers version to 1.11.3 (kubernetes-sigs#6694)
  ...
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants