Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-node playbook will always fail for non-etcd nodes #6690

Closed
lhw opened this issue Sep 16, 2020 · 0 comments · Fixed by #6719
Closed

remove-node playbook will always fail for non-etcd nodes #6690

lhw opened this issue Sep 16, 2020 · 0 comments · Fixed by #6719
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lhw
Copy link
Contributor

lhw commented Sep 16, 2020

Environment:

  • Cloud provider or hardware configuration:
    /
  • OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):
    CI Container: Debian GNU/Linux bullseye/sid
  • Version of Ansible (ansible --version):
    2.9.6
  • Version of Python (python --version):
    3.8.2

Kubespray version (commit) (git rev-parse --short HEAD):
2.14.0

Network plugin used:
Calico CNI

Full inventory with variables (ansible -i inventory/sample/inventory.ini all -m debug -a "var=hostvars[inventory_hostname]"):

Command used to invoke ansible:
ansible-playbook remove-node.yml -e "node=somenodes.at.local.domain,morenodes" -e "delete_nodes_confirmation=yes"

Output of ansible run:

fatal: [somenode.at.local.domain]: FAILED! => {
    "assertion": "node_ip is defined and node_ip | length > 0",
    "changed": false,
    "evaluated_to": false,
    "msg": "Etcd node ip is not set !"
}

Anything else do we need to know:
The change in #6603 did not include the lines

when:
  - inventory_hostname in groups['etcd']

so the remove-node playbook will always fail for non-etcd nodes.
I could quickly create a PR to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
1 participant