Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external_openstack_lbaas_provider setting for occm #6566

Merged
merged 4 commits into from
Sep 21, 2020
Merged

Add external_openstack_lbaas_provider setting for occm #6566

merged 4 commits into from
Sep 21, 2020

Conversation

piequi
Copy link
Contributor

@piequi piequi commented Aug 20, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:
Add a new parameter in openstack.yml to be able to specify a loadbalancerv2 service provider and update config template file to include this new parameter.

Which issue(s) this PR fixes:
Fixes #6565

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @piequi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2020
@floryut
Copy link
Member

floryut commented Aug 20, 2020

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2020
@floryut floryut mentioned this pull request Aug 20, 2020
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2020
@piequi
Copy link
Contributor Author

piequi commented Aug 20, 2020

@floryut sorry about that late commit

@floryut
Copy link
Member

floryut commented Aug 20, 2020 •
edited
Loading

Wait.. Why don't you change all that external_openstack_lbaas_use_octavia thing ? or keep it and set it to true when external_openstack_lbaas_provider is set to octavia ?

But I would prefer to remove it entirely and do a check line 22, something like use-octavia={{ external_openstack_lbaas_provider | lower == 'octavia' }} ?

@piequi
Copy link
Contributor Author

piequi commented Aug 20, 2020

That's a good point !
I'll simplify that as you suggested.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2020
@piequi
Copy link
Contributor Author

piequi commented Sep 7, 2020

@floryut do you think we could have some more reviewers for this change ?

@floryut
Copy link
Member

floryut commented Sep 17, 2020

@floryut do you think we could have some more reviewers for this change ?

All good for me, WDYT @Miouge1 ?
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Sep 18, 2020

@alijahnas any feedback on this openstack lbaas PR?

@alijahnas
Copy link
Contributor

@Miouge1 Sorry I wasn't very available lately to follow the PRs.

It is necessary to have this because in the latest versions of OpenStack, the LBaaS provider should be set to "amphora".
Using "octavia" as default is just for backwards compatibility with OpenStack Queens which is still used in production by many people. For example, it is one of the Long Term versions of Red Hat OpenStack Platform.

/lgtm

@floryut
Copy link
Member

floryut commented Sep 21, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, piequi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5ec2467 into kubernetes-sigs:master Sep 21, 2020
@piequi piequi deleted the add-openstack-lb-provider-config branch September 21, 2020 16:09
erulabs added a commit to kubesail/kubespray that referenced this pull request Sep 23, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
d068d01 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  remove variable 'etcd_ionice', because ionice removed from container image etcd:v3.4.x (kubernetes-sigs#6735)
  calico: default to using kdd datastore (kubernetes-sigs#6693)
  Update docker packages to 19.03.13 + add docker f32 (kubernetes-sigs#6712)
  Fix snapshot.storage apiVersion (kubernetes-sigs#6711)
  properly generate extravolumes in kubeadmconfig for centos (kubernetes-sigs#6708)
  Fix reserved memory unit in kubelet configuration (kubernetes-sigs#6725)
  Fix unintended SIGPIPE (kubernetes-sigs#6721)
  Expose offline install overrides in inventory (kubernetes-sigs#6728)
  Added ability to set calico vxlan vni and port. defaults to calico's … (kubernetes-sigs#6678)
  Change health check from TCP to HTTPS (kubernetes-sigs#6487)
  Add multi architeture support to flannel (kubernetes-sigs#6166)
  Remove pypi repo and pip extra flags (kubernetes-sigs#6729)
  Fails if kubeadm_version do not matches kubernetes version (kubernetes-sigs#6302)
  Add external_openstack_lbaas_provider setting for occm (kubernetes-sigs#6566)
  add new variable allowing additionnal audit webhook server options (kubernetes-sigs#6726)
  Fix example value for etcd_quota_backend_bytes (kubernetes-sigs#6724)
  Added support for setting tiller_service_account and tiller_replicas (kubernetes-sigs#6696)
@floryut floryut mentioned this pull request Dec 19, 2020
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
@piequi @LuckySB
Add external_openstack_lbaas_provider setting for occm (kubernetes-si…
73867ea 
…gs#6566)

* Add external_openstack_lbaas_provider setting for occm

* Integrate with existing lbaas_provider block

* Refactor lbaas_provider config template block

* Remove external_openstack_lbaas_use_octavia from sample inventory
@LuckySB LuckySB mentioned this pull request Feb 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huxcrux huxcrux huxcrux left review comments

@alijahnas alijahnas Awaiting requested review from alijahnas

@floryut floryut Awaiting requested review from floryut

Assignees

@floryut floryut

@alijahnas alijahnas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lb-provider setting to Openstack external cloud controller config
6 participants
@piequi @k8s-ci-robot @floryut @Miouge1 @alijahnas @huxcrux