-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use external_openstack_lbaas_use_octavia for template openstack-cloud… #7298
use external_openstack_lbaas_use_octavia for template openstack-cloud… #7298
Conversation
Hi @metanovii. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some openstack hosters want this configuration
...rnetes-apps/external_cloud_controller/openstack/templates/external-openstack-cloud-config.j2
Outdated
Show resolved
Hide resolved
please add some docs to openstack.md |
@LuckySB done |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LuckySB, metanovii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@metanovii You should rebase, CI error might be linked to the outdated branch status |
…d description and default values of variables to docs
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e298e0b
to
5847420
Compare
branch is updated but ci failed |
Thank you, not to worry this one is a random one, I've retried it |
...rnetes-apps/external_cloud_controller/openstack/templates/external-openstack-cloud-config.j2
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u mean like that?
Sorry for my unclear comment.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e2a327b
to
21d4d18
Compare
21d4d18
to
118fc5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself seems good for me, thanks for updating.
Just one comment about documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating.
/lgtm
kubernetes-sigs#7298) * use external_openstack_lbaas_use_octavia for template openstack-cloud-config * Delete external_openstack_lbaas_use_octavia from default values. Added description and default values of variables to docs * markdown fix * make this simple * set external_openstack_lbaas_use_octavia in default values * duplicated variable in doc
external_openstack_lbaas_use_octavia defined in roles/kubespray-defaults/defaults/main.yaml but not using
What type of PR is this?
/kind bug
What this PR does / why we need it:
In my case config must be like this
Which issue(s) this PR fixes:
Without issue
Special notes for your reviewer:
Does this PR introduce a user-facing change?: