Expose offline install overrides in inventory #6728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
size/M
|
For this issue #6540 we need a solution to setup the docker registry, deb repo and helm charts in automated way. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EppO, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Well, I would say that's a bit out of scope of Kubespray but that's only my pov. |
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Sep 23, 2020
* 'master' of https://github.com/kubernetes-sigs/kubespray: remove variable 'etcd_ionice', because ionice removed from container image etcd:v3.4.x (kubernetes-sigs#6735) calico: default to using kdd datastore (kubernetes-sigs#6693) Update docker packages to 19.03.13 + add docker f32 (kubernetes-sigs#6712) Fix snapshot.storage apiVersion (kubernetes-sigs#6711) properly generate extravolumes in kubeadmconfig for centos (kubernetes-sigs#6708) Fix reserved memory unit in kubelet configuration (kubernetes-sigs#6725) Fix unintended SIGPIPE (kubernetes-sigs#6721) Expose offline install overrides in inventory (kubernetes-sigs#6728) Added ability to set calico vxlan vni and port. defaults to calico's … (kubernetes-sigs#6678) Change health check from TCP to HTTPS (kubernetes-sigs#6487) Add multi architeture support to flannel (kubernetes-sigs#6166) Remove pypi repo and pip extra flags (kubernetes-sigs#6729) Fails if kubeadm_version do not matches kubernetes version (kubernetes-sigs#6302) Add external_openstack_lbaas_provider setting for occm (kubernetes-sigs#6566) add new variable allowing additionnal audit webhook server options (kubernetes-sigs#6726) Fix example value for etcd_quota_backend_bytes (kubernetes-sigs#6724) Added support for setting tiller_service_account and tiller_replicas (kubernetes-sigs#6696)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 16, 2021
* Expose offline install overrides in inventory * Remove not recommended warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
kube_image_repois defined twice (inventory and roles/download/defaults/main.yml).This PR also create a new offline.yml file in the inventory, all commented out by default, which is the central point of modification for air-gap installation.
Which issue(s) this PR fixes:
Fixes #6540
Fixes #6684
Special notes for your reviewer:
Docs for offline install changed accordingly
Does this PR introduce a user-facing change?: