-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use supported version of fedora in CI #10108
Use supported version of fedora in CI #10108
Conversation
877e9c6
to
fc89b18
Compare
There's something buggy with the new fedora image and networking :( |
I don't think I will have time to debug this in more details. If anyone is more knowledgeable on fedora and might know what is going, on feel free to have a look and send another PR with these commits/code or not... whatever works! |
Yup I used to maintain Fedora jobs and version but every f** time Fedora broke something with their version :< |
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
fc89b18
to
93e788d
Compare
a8ebf6a
to
93e788d
Compare
2c694b0
to
7ca5d71
Compare
Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it.
7ca5d71
to
f6acb01
Compare
We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Thanks @MrFreezeex /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this! @MrFreezeex thank you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
* Convert exoscale tf provider to new version (#10646) This is untested. It passes terraform validate to un-broke the CI. * specify pyyaml version to 5.3.1 Signed-off-by: bo.jiang <[email protected]> * Migrate CI_BUILD_ID to CI_JOB_ID and CI_BUILD_REF to CI_COMMIT_SHA (#10063) * Use supported version of fedora in CI (#10108) * tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: bo.jiang <[email protected]> Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> Co-authored-by: Max Gautier <[email protected]> Co-authored-by: Florian Ruynat <[email protected]> Co-authored-by: Arthur Outhenin-Chalandre <[email protected]>
* tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
* tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
* tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
* tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
* [kubernetes] Add hashes for kubernetes 1.26.11, 1.26.10 Make kubernetes 1.26.11 default * Workaround for yaml/pyyaml#601 * Convert exoscale tf provider to new version (#10646) This is untested. It passes terraform validate to un-broke the CI. * Update 0040-verify-settings.yml (#10699) remove embedded template * Use supported version of fedora in CI (#10108) * tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> Co-authored-by: piwinkler <[email protected]> Co-authored-by: Arthur Outhenin-Chalandre <[email protected]>
* tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Replace fedora35 by fedora37 and fedora36 in fedora38 in CI
Also update CentOS 7 image which can no longer validate some certificate
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: