Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.21] Ensure that CI is available #10673

Merged

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Nov 30, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

The current release 2.21 branch CI is not available.

  1. 🐛 cython_sources issue:
  1. 🐛 tf-validate-exoscale issue:
  1. 🐛 test_id issue:
  1. 🐛 requested fedora/36-cloud-base returned error 404:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


This is untested. It passes terraform validate to un-broke the CI.
@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Nov 30, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2023
@ErikJiang ErikJiang changed the title [2.21] Convert exoscale tf provider to new version (#10646) [2.21] Ensure that CI is available Nov 30, 2023
floryut and others added 2 commits November 30, 2023 15:44
* tests: replace fedora35 with fedora37

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* tests: replace fedora36 with fedora38

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* docs: update fedora version in docs

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* molecule: upgrade fedora version

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* tests: upgrade fedora images for vagrant and kubevirt

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* vagrant: workaround to fix private network ip address in fedora

Fedora stop supporting syconfig network script so we added a workaround
here
hashicorp/vagrant#12762 (comment)
to fix it.

* netowrkmanager: do not configure dns if using systemd-resolved

We should not configure dns if we point to systemd-resolved.
Systemd-resolved is using NetworkManager to infer the upstream DNS
server so if we set NetworkManager to 127.0.0.53 it will prevent
systemd-resolved to get the correct network DNS server.

Thus if we are in this case we just don't set this setting.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* image-builder: update centos7 image

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* gitlab-ci: mark fedora packet jobs as allow failure

Fedora networking is still broken on Packet, let's mark it as allow
failure for now.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

---------

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@yankay
Copy link
Member

yankay commented Dec 1, 2023

Thanks @ErikJiang

Great work
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, ErikJiang, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cyclinder
Copy link
Contributor

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit c3e73aa into kubernetes-sigs:release-2.21 Dec 1, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants