Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0040-verify-settings.yml #10699

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

piwinkler
Copy link
Contributor

@piwinkler piwinkler commented Dec 7, 2023

remove embedded template

@VannTen regarding your suggestion - changing with_items to loop, i leave that for now as it is, feel like this should not be a singled out modification

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

What this PR does / why we need it:
Assertation task fails with this syntax
Which issue(s) this PR fixes:

Fixes #10688

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix assertion for task item verify-settings

remove embedded template
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 7, 2023
Copy link

linux-foundation-easycla bot commented Dec 7, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 7, 2023
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten December 7, 2023 14:54
@k8s-ci-robot
Copy link
Contributor

Welcome @piwinkler!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @piwinkler. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 7, 2023
@cloudnull
Copy link

This fix worked for me. Thanks!

@yankay
Copy link
Member

yankay commented Dec 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2023
@VannTen
Copy link
Contributor

VannTen commented Dec 8, 2023

We should merge this ASAP, this blocks the CI on some PRs (not all of them thanks to build cache apparently ...). I don't have org membership yet for review unfortunately
/cc @MrFreezeex @floryut

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2023
@jimangel
Copy link
Member

/lgtm

I updated to latest kubespray via git pull and subsequent commands error that ansibe-core 2.15+ was required. Once I updated ansible-core (via pip install -r requirements.txt), I could run reset but it failed at this point:

TASK [kubernetes/preinstall : Stop if either kube_control_plane or kube_node group is empty] ***************************************************************************
fatal: [node1]: FAILED! => {"msg": "The conditional check 'groups.get('kube_control_plane')' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated."}

This minor change fixed my issue.

@jimangel jimangel removed their assignment Dec 10, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piwinkler Thank you for the PR 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, piwinkler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit eb628ef into kubernetes-sigs:master Dec 11, 2023
64 checks passed
VannTen pushed a commit to VannTen/kubespray that referenced this pull request Dec 11, 2023
VannTen pushed a commit to VannTen/kubespray that referenced this pull request Dec 11, 2023
k8s-ci-robot pushed a commit that referenced this pull request Dec 11, 2023
)

* kubernetes: add hashes for 1.27.8, 1.26.11

Make 1.27.8 default.

* Convert exoscale tf provider to new version (#10646)

This is untested. It passes terraform validate to un-broke the CI.

* Update 0040-verify-settings.yml (#10699)

remove embedded template

---------

Co-authored-by: piwinkler <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Dec 12, 2023
* [kubernetes] Add hashes for kubernetes 1.26.11, 1.26.10

Make kubernetes 1.26.11 default

* Workaround for yaml/pyyaml#601

* Convert exoscale tf provider to new version (#10646)

This is untested. It passes terraform validate to un-broke the CI.

* Update 0040-verify-settings.yml (#10699)

remove embedded template

* Use supported version of fedora in CI (#10108)

* tests: replace fedora35 with fedora37

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* tests: replace fedora36 with fedora38

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* docs: update fedora version in docs

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* molecule: upgrade fedora version

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* tests: upgrade fedora images for vagrant and kubevirt

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* vagrant: workaround to fix private network ip address in fedora

Fedora stop supporting syconfig network script so we added a workaround
here
hashicorp/vagrant#12762 (comment)
to fix it.

* netowrkmanager: do not configure dns if using systemd-resolved

We should not configure dns if we point to systemd-resolved.
Systemd-resolved is using NetworkManager to infer the upstream DNS
server so if we set NetworkManager to 127.0.0.53 it will prevent
systemd-resolved to get the correct network DNS server.

Thus if we are in this case we just don't set this setting.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* image-builder: update centos7 image

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

* gitlab-ci: mark fedora packet jobs as allow failure

Fedora networking is still broken on Packet, let's mark it as allow
failure for now.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

---------

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

---------

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Co-authored-by: piwinkler <[email protected]>
Co-authored-by: Arthur Outhenin-Chalandre <[email protected]>
@yankay yankay mentioned this pull request Dec 15, 2023
danykaufman pushed a commit to danykaufman/kubespray-offline that referenced this pull request Jan 1, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
8 participants