-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 0040-verify-settings.yml #10699
Conversation
remove embedded template
|
Welcome @piwinkler! |
Hi @piwinkler. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fix worked for me. Thanks! |
/ok-to-test |
We should merge this ASAP, this blocks the CI on some PRs (not all of them thanks to build cache apparently ...). I don't have org membership yet for review unfortunately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/ok-to-test
/lgtm
/lgtm I updated to latest kubespray via
This minor change fixed my issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piwinkler Thank you for the PR 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex, piwinkler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
remove embedded template
remove embedded template
) * kubernetes: add hashes for 1.27.8, 1.26.11 Make 1.27.8 default. * Convert exoscale tf provider to new version (#10646) This is untested. It passes terraform validate to un-broke the CI. * Update 0040-verify-settings.yml (#10699) remove embedded template --------- Co-authored-by: piwinkler <[email protected]>
* [kubernetes] Add hashes for kubernetes 1.26.11, 1.26.10 Make kubernetes 1.26.11 default * Workaround for yaml/pyyaml#601 * Convert exoscale tf provider to new version (#10646) This is untested. It passes terraform validate to un-broke the CI. * Update 0040-verify-settings.yml (#10699) remove embedded template * Use supported version of fedora in CI (#10108) * tests: replace fedora35 with fedora37 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: replace fedora36 with fedora38 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * docs: update fedora version in docs Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * molecule: upgrade fedora version Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: upgrade fedora images for vagrant and kubevirt Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * vagrant: workaround to fix private network ip address in fedora Fedora stop supporting syconfig network script so we added a workaround here hashicorp/vagrant#12762 (comment) to fix it. * netowrkmanager: do not configure dns if using systemd-resolved We should not configure dns if we point to systemd-resolved. Systemd-resolved is using NetworkManager to infer the upstream DNS server so if we set NetworkManager to 127.0.0.53 it will prevent systemd-resolved to get the correct network DNS server. Thus if we are in this case we just don't set this setting. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * image-builder: update centos7 image Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * gitlab-ci: mark fedora packet jobs as allow failure Fedora networking is still broken on Packet, let's mark it as allow failure for now. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> Co-authored-by: piwinkler <[email protected]> Co-authored-by: Arthur Outhenin-Chalandre <[email protected]>
remove embedded template
remove embedded template
@VannTen regarding your suggestion - changing with_items to loop, i leave that for now as it is, feel like this should not be a singled out modification
What type of PR is this?
/kind bug
What this PR does / why we need it:
Assertation task fails with this syntax
Which issue(s) this PR fixes:
Fixes #10688
Special notes for your reviewer:
Does this PR introduce a user-facing change?: