Test: Add isActive flow tests for TimeTableViewModel #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksharma-xyz
changed the title
This was referenced Jan 8, 2025
This was referenced Jan 8, 2025
ksharma-xyz
force-pushed
the
01-08-add_ut_for_analytics
branch
from
1dfe560 to
ca7c4fe
Compare
ksharma-xyz
force-pushed
the
01-08-add_ut_for_isatcive_flow
branch
from
c04aa00 to
89a7bc0
Compare
ksharma-xyz
force-pushed
the
01-08-add_ut_for_analytics
branch
from
ca7c4fe to
6843440
Compare
ksharma-xyz
force-pushed
the
01-08-add_ut_for_isatcive_flow
branch
2 times, most recently
from
5f337b3 to
e1af3f1
Compare
ksharma-xyz
force-pushed
the
01-08-add_ut_for_isatcive_flow
branch
from
e1af3f1 to
533f406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added test coverage for TimeTable's isActive flow and exposed REFRESH_TIME_TEXT_DURATION for testing
What changed?
How to test?
GIVEN journeyList is empty in UI State WHEN REFRESH_TIME_TEXT_DURATION passes THEN updateTimeText is not calledpassesWhy make this change?
To improve test coverage of the TimeTable feature, specifically around the isActive flow functionality which controls time text updates. This ensures the time-based refresh behavior works correctly when the journey list is empty and sets up structure for testing non-empty journey list scenarios.