Test: Add SaveTrip event tests and clear analytics state #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2025
This was referenced Jan 8, 2025
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
01-06-add_ut_-_test_remove_completed_journey_from_the_cache
branch
from
2fa6387 to
b63ad3a
Compare
ksharma-xyz
force-pushed
the
01-06-add_ut_for_savetripbuttonclicked
branch
from
4346c0f to
bda18a9
Compare
ksharma-xyz
force-pushed
the
01-06-add_ut_-_test_remove_completed_journey_from_the_cache
branch
2 times, most recently
from
bcf322f to
964359d
Compare
ksharma-xyz
force-pushed
the
01-06-add_ut_for_savetripbuttonclicked
branch
2 times, most recently
from
8aad355 to
7bdaead
Compare
ksharma-xyz
changed the base branch from
01-06-add_ut_-_test_remove_completed_journey_from_the_cache
to
graphite-base/518
ksharma-xyz
force-pushed
the
graphite-base/518
branch
from
964359d to
f92f5db
Compare
ksharma-xyz
force-pushed
the
01-06-add_ut_for_savetripbuttonclicked
branch
from
7bdaead to
7ba6da6
Compare
ksharma-xyz
force-pushed
the
01-06-add_ut_for_savetripbuttonclicked
branch
from
7ba6da6 to
71a5a61
Compare
Merge activity
|
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added trip saving functionality and analytics tracking to TimeTableViewModel with corresponding tests
What changed?
clear()function to FakeAnalytics to reset tracked events and user IDWhy make this change?
To ensure proper test coverage for the trip saving functionality and analytics tracking in the TimeTableViewModel, making the codebase more reliable and maintainable. The addition of the clear() function in FakeAnalytics helps prevent test pollution between different test cases.