Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add retry and journey card click tests for TimeTableViewModel #520

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 8, 2025

TL;DR

Added unit tests for retry button and journey card click functionality in TimeTableViewModel

What changed?

  • Added test to verify retry button reloads trip information
  • Added test to verify journey card click events trigger appropriate analytics tracking for expand/collapse actions

How to test?

  1. Run the test suite for TimeTableViewModelTest
  2. Verify the new tests pass:
    • GIVEN trip info WHEN RetryButtonClicked is triggered THEN trip should be reloaded
    • GIVEN a trip with journey list WHEN JourneyCardClicked is triggered THEN analytics event for collapse or expand is triggered

Why make this change?

To increase test coverage and ensure proper functionality of the retry button and journey card click interactions in the TimeTableViewModel

@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 8, 2025 09:17
@ksharma-xyz ksharma-xyz force-pushed the 01-06-add_ut_for_reversetripbuttonclicked branch from 0a37dcf to d3fb5a1 Compare January 8, 2025 09:18
@ksharma-xyz ksharma-xyz force-pushed the 01-08-add_ut_for_timetableviewmodel branch from 2528f95 to c81e85e Compare January 8, 2025 09:18
@ksharma-xyz ksharma-xyz force-pushed the 01-06-add_ut_for_reversetripbuttonclicked branch 2 times, most recently from a0f0464 to 2c2185c Compare January 8, 2025 09:32
@ksharma-xyz ksharma-xyz force-pushed the 01-08-add_ut_for_timetableviewmodel branch from c81e85e to 0562c83 Compare January 8, 2025 09:32
@ksharma-xyz ksharma-xyz changed the base branch from 01-06-add_ut_for_reversetripbuttonclicked to graphite-base/520 January 8, 2025 09:43
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/520 to main January 8, 2025 09:43
@ksharma-xyz ksharma-xyz force-pushed the 01-08-add_ut_for_timetableviewmodel branch from 0562c83 to 612a710 Compare January 8, 2025 09:43
@ksharma-xyz ksharma-xyz force-pushed the 01-08-add_ut_for_timetableviewmodel branch from 612a710 to de933e2 Compare January 8, 2025 09:44

Verified

This commit was signed with the committer’s verified signature.
mifi Mikael Finstad
@ksharma-xyz ksharma-xyz force-pushed the 01-08-add_ut_for_timetableviewmodel branch from de933e2 to 6752789 Compare January 8, 2025 10:24
@ksharma-xyz ksharma-xyz merged commit 315e22b into main Jan 8, 2025
2 checks passed
Copy link
Owner Author

Merge activity

  • Jan 8, 5:35 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 01-08-add_ut_for_timetableviewmodel branch January 8, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant