-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Add retry and journey card click tests for TimeTableViewModel #520
Merged
+72
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2025
This was referenced Jan 8, 2025
0a37dcf
to
d3fb5a1
Compare
2528f95
to
c81e85e
Compare
a0f0464
to
2c2185c
Compare
c81e85e
to
0562c83
Compare
0562c83
to
612a710
Compare
612a710
to
de933e2
Compare
This was referenced Jan 8, 2025
de933e2
to
6752789
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added unit tests for retry button and journey card click functionality in TimeTableViewModel
What changed?
How to test?
GIVEN trip info WHEN RetryButtonClicked is triggered THEN trip should be reloaded
GIVEN a trip with journey list WHEN JourneyCardClicked is triggered THEN analytics event for collapse or expand is triggered
Why make this change?
To increase test coverage and ensure proper functionality of the retry button and journey card click interactions in the TimeTableViewModel