Test: Add journey cache cleanup tests for TimeTableViewModel #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2025
This was referenced Jan 8, 2025
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
01-06-test_for_updatetripscache
branch
2 times, most recently
from
ae779c7 to
e114879
Compare
ksharma-xyz
force-pushed
the
01-06-add_ut_-_test_remove_completed_journey_from_the_cache
branch
from
2fa6387 to
b63ad3a
Compare
ksharma-xyz
changed the base branch from
01-06-test_for_updatetripscache
to
graphite-base/517
ksharma-xyz
force-pushed
the
01-06-add_ut_-_test_remove_completed_journey_from_the_cache
branch
from
b63ad3a to
bcf322f
Compare
ksharma-xyz
force-pushed
the
graphite-base/517
branch
from
e114879 to
571f489
Compare
ksharma-xyz
force-pushed
the
01-06-add_ut_-_test_remove_completed_journey_from_the_cache
branch
from
bcf322f to
964359d
Compare
ksharma-xyz
deleted the
01-06-add_ut_-_test_remove_completed_journey_from_the_cache
branch
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added functionality to clear completed journeys from the timetable cache after a threshold time.
What changed?
buildStartedJourneysListtest helper to support creating completed journeysJOURNEY_ENDED_CACHE_THRESHOLD_TIMEvisible for testing purposesWhy make this change?
To prevent the accumulation of stale journey data in the cache by automatically removing completed journeys after a specified threshold time (10 minutes). This helps maintain optimal performance and ensures users see only relevant journey information.