Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Add DeleteSavedTrip event test and improve test naming #510

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Test: Add DeleteSavedTrip event test and improve test naming #510

merged 1 commit into from
Jan 6, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 5, 2025 •
edited
Loading

TL;DR

Added test coverage for saved trip deletion and improved test naming conventions

What changed?

  • Added new test case for verifying saved trip deletion functionality
  • Renamed existing test cases to follow Given/When/Then pattern
  • Enhanced test readability with clear state setup and verification steps
  • Added spacing in SavedTripsViewModel event handling for better code readability

Why make this change?

To improve test coverage and maintainability by:

  • Ensuring the delete functionality works as expected
  • Making test intentions clearer through better naming
  • Following consistent testing patterns across the codebase
  • Providing better verification of UI state changes

@ksharma-xyz Graphite App
Copy link
Owner Author

ksharma-xyz commented Jan 5, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz mentioned this pull request Jan 5, 2025
Merged
@ksharma-xyz ksharma-xyz added this to the 1.0.5 milestone Jan 5, 2025
@ksharma-xyz ksharma-xyz force-pushed the 01-05-add_ut_for_deletesavedtrip branch from c6ccdf9 to 282aaed Compare January 5, 2025 05:54
This was referenced Jan 5, 2025
Merged
Merged
Merged
Merged
Base automatically changed from 01-05-add_ut_for_savedtripuievent.loadsavedtrips to main January 6, 2025 06:01
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 6, 2025 06:15
@ksharma-xyz ksharma-xyz force-pushed the 01-05-add_ut_for_deletesavedtrip branch from 282aaed to 960ad4a Compare January 6, 2025 06:15
@ksharma-xyz ksharma-xyz changed the title Add UT for DeleteSavedTrip Test: Add DeleteSavedTrip event test and improve test naming Jan 6, 2025
@ksharma-xyz ksharma-xyz merged commit 4a7c6b4 into main Jan 6, 2025
2 checks passed
@ksharma-xyz Graphite App
Copy link
Owner Author

Merge activity

  • Jan 6, 1:26 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 01-05-add_ut_for_deletesavedtrip branch January 6, 2025 06:26
This was referenced Jan 6, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Krail - NSW Trip Planning
Status: Done
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.
1 participant
@ksharma-xyz