Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context sensitive Bash completion #1373

Closed
5 of 6 tasks
rhuss opened this issue Jul 9, 2021 · 9 comments · Fixed by #1547, #1560, #1561, #1559 or #1562
Closed
5 of 6 tasks

Context sensitive Bash completion #1373

rhuss opened this issue Jul 9, 2021 · 9 comments · Fixed by #1547, #1560, #1561, #1559 or #1562
Assignees
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented Jul 9, 2021

Feature request

kn completion is currently based on the auto generation of the bash/zsh completion code by cobra. It lacks the the possibility to complete on context sensitive information likes service or revision names, something that e.g. kubectl allows.

We should extend the completion code to allow completion on those resources. The way how kubectl does it could be taken as an inspiration.

UI Example

kn service describe my<TAB>

would complete to "myservice" if there would be a Knative service installed that is called "myservice".

Here are the smaller issues tracked by this issue:

@rhuss rhuss added kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage) labels Jul 9, 2021
@rhuss rhuss moved this to Backlog in Client Planning Nov 16, 2021
@rhuss
Copy link
Contributor Author

rhuss commented Nov 17, 2021

Let's add #1374 first and then continue with this story.

@vyasgun
Copy link
Contributor

vyasgun commented Jan 4, 2022

@rhuss @dsimansk should we reopen this as only one resource has been addressed?

@rhuss
Copy link
Contributor Author

rhuss commented Jan 4, 2022

Good point, let's keep this issue for tracking the overall story.

@rhuss rhuss reopened this Jan 4, 2022
@rhuss rhuss moved this from Done to In Progress in Client Planning Jan 4, 2022
@rhuss rhuss moved this to In Progress in Client 1.2 (0.28) Jan 5, 2022
@rhuss
Copy link
Contributor Author

rhuss commented Jan 5, 2022

Repository owner moved this from In Progress to Done in Client Planning Jan 10, 2022
Repository owner moved this from In Progress to Done in Client 1.2 (0.28) Jan 10, 2022
@vyasgun
Copy link
Contributor

vyasgun commented Jan 10, 2022

Sorry about the mess from too many PRs. I think we can reopen the issue and I can create subtasks for the remaining resources so this doesn't get closed before completion

@dsimansk
Copy link
Contributor

/reopen

@knative-prow-robot
Copy link
Contributor

@dsimansk: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Repository owner moved this from Done to Ready To Work in Client Planning Jan 11, 2022
This was linked to pull requests Jan 11, 2022
Repository owner moved this from Ready To Work to Done in Client Planning Jan 12, 2022
@vyasgun
Copy link
Contributor

vyasgun commented Jan 12, 2022

/reopen

@knative-prow-robot
Copy link
Contributor

@vyasgun: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Repository owner moved this from Done to Ready To Work in Client Planning Jan 12, 2022
Repository owner moved this from Ready To Work to Done in Client Planning Jan 18, 2022
@rhuss rhuss added this to the v0.28 milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment