-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added completion for route name #1561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasgun: 0 warnings.
In response to this:
Description
Added completion function for autocompleting route name in
kn route describe
commandChanges
- Added completion function to
route describe
subcommand- Added tests for the above
Reference
Fixes #1373
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
+ Coverage 79.61% 79.63% +0.01%
==========================================
Files 163 163
Lines 8580 8597 +17
==========================================
+ Hits 6831 6846 +15
- Misses 1070 1071 +1
- Partials 679 680 +1
Continue to review full report at Codecov.
|
/retest |
f33276a
to
ab3c375
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added completion function for autocompleting route name in
kn route describe
commandChanges
route describe
subcommandReference
Fixes #1373