-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added completion for revision resource #1560
Added completion for revision resource #1560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasgun: 0 warnings.
In response to this:
Description
Added completion function to revision describe and delete subcommands
Changes
- Added function for revision name completion
- Added unit tests for above
Reference
Fixes #1373
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
@@ Coverage Diff @@
## main #1560 +/- ##
==========================================
+ Coverage 79.59% 79.61% +0.01%
==========================================
Files 163 163
Lines 8562 8580 +18
==========================================
+ Hits 6815 6831 +16
- Misses 1069 1070 +1
- Partials 678 679 +1
Continue to review full report at Codecov.
|
@vyasgun can you please rebase? IMO it looks good, we can one by one, since there's going to be conflict in |
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Added completion function to revision describe and delete subcommands
Changes
Reference
Fixes #1373