Added completion for domain command

[vyasgun]

Description

Added auto completion function for domain command

Changes

• Added auto completion function for domain command
• Added unit tests for the above

Reference

[knative-prow-robot]

@vyasgun: 0 warnings.

In response to this:

Description

Added auto completion function for domain command

Changes

• Added auto completion function for domain command
• Added unit tests for the above

Reference

Fixes #1373

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1562 (f192bcb) into main (07d0cd7) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
+ Coverage   79.63%   79.65%   +0.02%     
==========================================
  Files         163      163              
  Lines        8597     8616      +19     
==========================================
+ Hits         6846     6863      +17     
- Misses       1071     1072       +1     
- Partials      680      681       +1     

Impacted Files	Coverage Δ
pkg/kn/commands/completion_helper.go	89.56% <88.23%> (-0.34%)	⬇️
pkg/kn/commands/domain/delete.go	82.60% <100.00%> (+0.79%)	⬆️
pkg/kn/commands/domain/describe.go	81.13% <100.00%> (+0.36%)	⬆️
pkg/kn/commands/domain/update.go	66.66% <100.00%> (+0.95%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d0cd7...f192bcb. Read the comment docs.

[dsimansk]

Since that's going to be the last conflict. Maybe, I'd order the list alphabetically by the resource name for the better overview.

[vyasgun]

Thanks, I reordered.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/completion_helper.go	95.0%	94.9%	-0.1

[maximilien]

Wondering if we really should have completion helper for delete?

Also, is this worth adding some docs to README or perhaps a simple ascii recoding?

[vyasgun]

@maximilien delete needs a resource name so I think there should be completion suggestions.

[dsimansk]

Wondering if we really should have completion helper for delete?

Also, is this worth adding some docs to README or perhaps a simple ascii recoding?

IMO, it should be consistent across the commands, therefore once there's NAME arg required such command should have completion enabled.

@maximilien I'd suggest to continue with merging this PR, as it's part of "add completion" issue and maybe continue the further discussion about delete case there. Wdyt?

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment