MBL-1567: Pledge redemption (Backer Shipping Expectation & Backer Shipping Country) #2112
+5,789
−5,825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/pledge-redemption-ml1
…ure/pledge-redemption-ml1
…r/android-oss into feature/pledge-redemption-ml1
…ure/pledge-redemption-ml1
…ure/pledge-redemption-ml1
…ure/pledge-redemption-ml1
…es user journeys. (#2081)
…ure/pledge-redemption-ml1
…ure/pledge-redemption-ml1
…ure/pledge-redemption-ml1
* add estimated shipping costs for rewards and add-ons * put shipping amount back into add-ons * fix unit tests
…ure/pledge-redemption-ml1
…ure/pledge-redemption-ml1
….com:kickstarter/android-oss into feature/pledge-redemption-ml1
* add estimated shipping visuals to pledge checkout screens * fix shipping amount being pulled from shipping rules and not the reward shipping rules * make it so late pledges are also shown "Pledge $$$"
…ure/pledge-redemption-ml1
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2112 +/- ##
============================================
+ Coverage 67.51% 67.66% +0.15%
- Complexity 2133 2189 +56
============================================
Files 364 367 +3
Lines 22186 22563 +377
Branches 3116 3236 +120
============================================
+ Hits 14979 15268 +289
+ Misses 5568 5560 -8
- Partials 1639 1735 +96 ☔ View full report in Codecov by Sentry. |
mtgriego
approved these changes
Aug 28, 2024
Comment on lines
+115
to
+124
| // val location = Location.builder() | ||
| // .id(23424814) | ||
| // .country("FK") | ||
| // .displayableName("Falkland Islands") | ||
| // .name("Falkland Islands") | ||
| // .build() | ||
| // return ShippingRule.builder() | ||
| // .id(23424814) | ||
| // .location(location) | ||
| // .build() |
There was a problem hiding this comment.
dont think we need this comment anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
📌 Backer Shipping Expectations
As a backer, I understand how much I will likely be charged for shipping when I back a campaign so that I can anticipate my total costs.
Will Do Rename shipping to estimated shipping
Will Do Show backers an estimated range for shipping
Will Do Rearrange UI components on existing checkout screens
As a backer, I won’t be charged for shipping until I have been sent to pledge redemption.
As a backer, I understand the rest of the flow and the aspects I will be responsible for.
📌 Backer Shipping Country
As a backer, I can easily set my shipping country so that I can view rewards that are available to me.
Will Do Move shipping country selector from “Confirm Details” to rewards carousel.
Will Do Rearrange UI on existing checkout screens.
🤔 Why
🛠 How
| | |
📋 QA
disable_shipping_at_pledge:Story 📖
MBL-1567