Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1573: Testing + small UI details #2107

Merged

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented Aug 21, 2024

📲 What

  • Added a bunch of testing
  • Small UI additions

🤔 Why

  • Wanna be sure we do not have bugs
  • Confidence changing/modifying/adding code in the future

👀 See

Screenshot 2024-08-21 at 3 23 20 PM
Screenshot 2024-08-21 at 3 22 28 PM

| | |

📋 QA

  • on Crowdfund for the deadline disclaimer go to any project and navigate to the checkout screen

Story 📖

MBL-1573

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (0329373) to head (cb429e4).

Files Patch % Lines
...ui/views/compose/checkout/PledgeItemizedDetails.kt 0.00% 13 Missing ⚠️
...i/activities/compose/projectpage/CheckoutScreen.kt 0.00% 9 Missing ⚠️
...ewmodels/projectpage/CrowdfundCheckoutViewModel.kt 66.66% 0 Missing and 4 partials ⚠️
...iewmodels/usecases/SendThirdPartyEventUseCaseV2.kt 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feature/pledge-redemption-ml1    #2107      +/-   ##
===================================================================
+ Coverage                            66.71%   67.75%   +1.03%     
- Complexity                            2136     2183      +47     
===================================================================
  Files                                  366      366              
  Lines                                22462    22491      +29     
  Branches                              3216     3224       +8     
===================================================================
+ Hits                                 14985    15238     +253     
+ Misses                                5791     5515     -276     
- Partials                              1686     1738      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang self-assigned this Aug 22, 2024
@Arkariang Arkariang added the Pledge Redemption PRs related to Pledge Redemption 2024 label Aug 22, 2024
@Arkariang Arkariang marked this pull request as ready for review August 22, 2024 15:57
Copy link
Contributor

@leighdouglas leighdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Arkariang Arkariang merged commit 34d787c into feature/pledge-redemption-ml1 Aug 22, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1573-unit-test-checkout branch August 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pledge Redemption PRs related to Pledge Redemption 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants