MBL-1573: Checkout Screen (Pledge and update payment method flows for crowdfund) #2096
+674
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update backing mutation called - Analytic events sent - Third party events sent
Arkariang
changed the title
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/pledge-redemption-ml1 #2096 +/- ##
===================================================================
- Coverage 68.26% 67.43% -0.84%
Complexity 2136 2136
===================================================================
Files 365 366 +1
Lines 21965 22237 +272
Branches 3120 3158 +38
===================================================================
Hits 14995 14995
- Misses 5296 5568 +272
Partials 1674 1674 ☔ View full report in Codecov by Sentry. |
Arkariang
commented
Aug 14, 2024
| import com.kickstarter.ui.fragments.PledgeFragment | ||
|
|
||
| fun Fragment.selectPledgeFragment( | ||
| pledgeData: PledgeData, | ||
| pledgeReason: PledgeReason | ||
| ): Fragment { | ||
| return PledgeFragment().withData(pledgeData, pledgeReason) | ||
| val fragment = if (pledgeReason == PledgeReason.FIX_PLEDGE) { |
There was a problem hiding this comment.
Notice here we can decide which crowdfund flows will use the new UI + VM
Arkariang
commented
Aug 14, 2024
| * - When updating payment method with a previously existing payment source | ||
| * - Updating any other parameter like location, amount or rewards | ||
| */ | ||
| fun getUpdateBackingData( |
There was a problem hiding this comment.
Package level method
…r/android-oss into imartin/MBL-1573
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
👀 See
PledgeAndChangePaymentMethod.mp4
| | |
📋 QA
Story 📖
MBL-1573