MBL-1573: Checkout Screen (Reward noReward for crowdfund and late pledges UI) #2104
+207
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkariang
commented
Aug 19, 2024
| @@ -188,7 +188,7 @@ fun RewardCarouselScreen( | |||
| ) { reward -> | |||
|
|
|||
| val ctaButtonEnabled = when { | |||
| RewardUtils.isNoReward(reward) && (project.postCampaignPledgingEnabled() ?: false && project.isInPostCampaignPledgingPhase() ?: false) -> true | |||
| RewardUtils.isNoReward(reward) -> true | |||
There was a problem hiding this comment.
Assuming now the Rewards carousel screen is being used un both crowdfund and late pledges a Reward no reward is always available. But @leighdouglas @mtgriego let me know if I'm missing any use case here
mtgriego
approved these changes
Aug 19, 2024
Base automatically changed from
imartin/MBL-1573-change-reward-flow
to
feature/pledge-redemption-ml1
August 19, 2024 23:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
New checkout screen using late pledges UI + entirely new VM
⚠️ Some UI small pieces will come
⚠️ Still work in progress more PR's will come with bunch of testing for the new VM!
👀 See
RewardNoRewardCrowdfund.mp4
RewardNoRewardLatePledges.mp4
| | |
📋 QA
Story 📖
MBL-1573