Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2409] Update docs to remind on compatibility of Kedro-Viz 3.8.0 with Kedro 0.17 #367

Merged
merged 9 commits into from
Feb 11, 2021

Conversation

studioswong
Copy link
Contributor

Description

Related ticket: https://jira.quantumblack.com/browse/KED-2409

This ticket is raised given the imcompatibility issues experienced by Go, which raises the need to update our docs to remind our users of compatibility issues and to update to the latest version of Kedro to install and run the latest version of Kedro-Viz.

Development notes

I have updated both the readme and the contributing docs.

QA notes

N/A

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@yetudada
Copy link
Contributor

yetudada commented Feb 5, 2021

Could we also add it to the RELEASE.md too?

Copy link
Contributor

@yetudada yetudada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments on capitalisation but otherwise I'm all happy. Thank you @studioswong!

@richardwestenra richardwestenra changed the title [KED-2409] update docs to remind on compatibility of Kedro-Viz 3.8.0 with Kedro 0.17 [KED-2409] Update docs to remind on compatibility of Kedro-Viz 3.8.0 with Kedro 0.17 Feb 6, 2021
studioswong and others added 3 commits February 8, 2021 09:47
Co-authored-by: Yetunde Dada <[email protected]>
Co-authored-by: Yetunde Dada <[email protected]>
Co-authored-by: Yetunde Dada <[email protected]>
@@ -23,6 +23,8 @@ This project was bootstrapped with [Create React App](https://github.com/faceboo

> For in-depth development and usage notes, see the [Contribution Guidelines](https://github.com/quantumblacklabs/kedro-viz/blob/main/CONTRIBUTING.md).

> It's likely that Kedro-Viz>=3.8.0 will not work with projects created with older versions of Kedro<=0.16.6. Please migrate your project to Kedro>=0.17.0 before installation of the latest version of Kedro-Viz.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> It's likely that Kedro-Viz>=3.8.0 will not work with projects created with older versions of Kedro<=0.16.6. Please migrate your project to Kedro>=0.17.0 before installation of the latest version of Kedro-Viz.
> It's likely that Kedro-Viz>=3.8.0 will not work with projects created with older versions of Kedro<=0.16.6. Please migrate your project to Kedro>=0.17.0 before you install the latest version of Kedro-Viz.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It's likely..." is one of those terms that fills me with concern. Will it? Won't it? How will I know? I think we need to be definite and say it won't.

Copy link
Contributor Author

@studioswong studioswong Feb 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for raising this @stichbury ! From our testing, Kedro-Viz 3.8.0 will work with older versions of Kedro, however the problem lies with many users running latest Kedro viz on Kedro 17 against

Regardless, for the wording I had taken the exact same wording that was in the Kedro release notes ( please see below conversation on slack) - my approach here is to follow what was stated in the kedro-release notes ( given that this incompatibility was not introduced by Kedro-viz but rather with the new Kedro upgrades.) The point of including this note here is just merely to reinterate / plug the gap.

image

I am not sure we can say it won't since actually it would work on older versions of Kedro ( provided it's on Kedro 16 with Kedro 16 project), but it could likely won't because of the incompatibility between the kedro project and kedro. @yetudada @stichbury would love your thoughts on how I should proceed with this sticky situation?

Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

studioswong and others added 2 commits February 11, 2021 14:18
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
@studioswong studioswong merged commit a535c71 into main Feb 11, 2021
@studioswong studioswong deleted the fix/KED-2409-update-docs branch February 11, 2021 14:32
@richardwestenra richardwestenra mentioned this pull request Feb 17, 2021
1 task
richardwestenra added a commit that referenced this pull request Feb 19, 2021
# Release 3.9.0

## Major features and improvements

- Add code panel (#346)
- Improve view panning behaviour when a node is selected (#356, #363, #370, #373, #374)
- Improve layout performance for large graphs (#343)
- Save tag state to localStorage (#353)

## Bug fixes and other changes

- Improve graph layout code quality, performance and docs (#347)
- Update docs to remind on compatibility of Kedro-Viz 3.8.0 with Kedro 0.17 (#367)
- Update dependencies (#360, #364, #369)
- Fix failing CircleCI build on Windows (#365, #366)
- Refactor node-list-row CSS, fixing hover and focus states (#355, #358, #362)
- Update iconography (#357, #359)
- Fix missing indicator Chrome zoom bug (#349)
- Fix sidebar border/box-shadow CSS rules (#351)
- Fix server.py to work with versions >0.17 and update contributing docs (#348)
- Fix errors when scrolling with empty pipeline (#342)
- Ignore coverage on some branches and fix e2e tests (#345)
- Fix icon-button tooltips on mobile (#344)
- Update SVG-Crowbar to fix errors (#339)
- Update contributing docs for new dev server (#341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants