Update iconography #357
Merged
Update iconography #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is no longer needed now that the paths for the relevant icons have been converted to strokes
These attributes aren't necessary when SVGs are embeddded in HTML. See: - https://html.spec.whatwg.org/multipage/syntax.html#foreign-elements - https://stackoverflow.com/a/18468348/1651713
|
Looks good! A minor thing, might just need my eyes to adjust, but do you think the layers icon might need to be a little smaller here? Say |
|
@bru5 I had the same thought - it wasn't included in this icon set so I wasn't able to update it. I'd prefer to update the SVG rather than use CSS. I'll ping @GabrielComymQB about it. |
|
@bru5 Have updated the layers icon with @GabrielComymQB's approval: |
bru5
approved these changes
Jan 25, 2021
richardwestenra
added a commit
that referenced
this pull request
Feb 19, 2021
# Release 3.9.0 ## Major features and improvements - Add code panel (#346) - Improve view panning behaviour when a node is selected (#356, #363, #370, #373, #374) - Improve layout performance for large graphs (#343) - Save tag state to localStorage (#353) ## Bug fixes and other changes - Improve graph layout code quality, performance and docs (#347) - Update docs to remind on compatibility of Kedro-Viz 3.8.0 with Kedro 0.17 (#367) - Update dependencies (#360, #364, #369) - Fix failing CircleCI build on Windows (#365, #366) - Refactor node-list-row CSS, fixing hover and focus states (#355, #358, #362) - Update iconography (#357, #359) - Fix missing indicator Chrome zoom bug (#349) - Fix sidebar border/box-shadow CSS rules (#351) - Fix server.py to work with versions >0.17 and update contributing docs (#348) - Fix errors when scrolling with empty pipeline (#342) - Ignore coverage on some branches and fix e2e tests (#345) - Fix icon-button tooltips on mobile (#344) - Update SVG-Crowbar to fix errors (#339) - Update contributing docs for new dev server (#341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Development notes
The most noteworthy thing is that many of the icons' paths lengths have changed, and some of them are a bit less complex, being outlined rather than stroked. This has allowed some of them to be simplified.
QA notes
The differences are subtle - mainly, some of the icons are a little smaller - especially the theme, text labels, and minimap icons. The best way to compare them is to open the demo page in another tab and switch back and forth between the dev site and the demo.
Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.