[KED-2331] Fix missing indicators Chrome zoom bug #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studioswong
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
Just tested this with a very large pipeline, and the blue dots aren't missing on zoom, great job @bru5 !
Looking at the fix, I wonder how a difference of 0.1 on the strokeWidth makes such a difference in its rendering in chrome? Does it always need to stay below a value of 2 in order for it to be rendered correctly on chrome?
|
@studioswong I actually didn't go any further into it at this time, there could be other problem values but since this isn't a dynamic SVG I think it's fine here - hopefully they fix the browser bug (if that's the case), but continue to test for this just in case |
richardwestenra
added a commit
that referenced
this pull request
Feb 19, 2021
# Release 3.9.0 ## Major features and improvements - Add code panel (#346) - Improve view panning behaviour when a node is selected (#356, #363, #370, #373, #374) - Improve layout performance for large graphs (#343) - Save tag state to localStorage (#353) ## Bug fixes and other changes - Improve graph layout code quality, performance and docs (#347) - Update docs to remind on compatibility of Kedro-Viz 3.8.0 with Kedro 0.17 (#367) - Update dependencies (#360, #364, #369) - Fix failing CircleCI build on Windows (#365, #366) - Refactor node-list-row CSS, fixing hover and focus states (#355, #358, #362) - Update iconography (#357, #359) - Fix missing indicator Chrome zoom bug (#349) - Fix sidebar border/box-shadow CSS rules (#351) - Fix server.py to work with versions >0.17 and update contributing docs (#348) - Fix errors when scrolling with empty pipeline (#342) - Ignore coverage on some branches and fix e2e tests (#345) - Fix icon-button tooltips on mobile (#344) - Update SVG-Crowbar to fix errors (#339) - Update contributing docs for new dev server (#341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids missing tag indicators when zoomed in Chrome.
Development notes
There appears to be a Chrome rendering issue with SVG strokes when zoomed.
The workaround here is to change the
strokeWidth(slightly) of the icon to a value that doesn't fail when zoomed.A comment was added to make note of this.
QA notes
First check out the main branch and open the demo in Chrome. Select a few random tags. Then zoom the browser in and out a few steps until some of the unselected tag indicators disappear.
Then switch to the fix branch and confirm this no longer happens.
Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.