Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ioctl] Build hdwallet create command line into new ioctl #3470

Merged
merged 9 commits into from
Jun 29, 2022
Merged

[ioctl] Build hdwallet create command line into new ioctl #3470

merged 9 commits into from
Jun 29, 2022

Conversation

LuckyPigeon
Copy link
Contributor

Description

Refactor hdwalletcreate command in new ioctl, with the following note.

  • Use client interface to construct the Cobra command.
  • Output package is deprecated, replace it with errors package.
  • Replace fmt.Println with cmd.Println
  • Refactor unit test to cover the modification.

Fixes #3283

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • TestNewHdwalletCreateCmd

Test Configuration:

  • Firmware version: Ubuntu 21.04
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #3470 (52366e6) into master (3037d8e) will increase coverage by 0.00%.
The diff coverage is 89.65%.

@@           Coverage Diff           @@
##           master    #3470   +/-   ##
=======================================
  Coverage   75.06%   75.07%           
=======================================
  Files         243      244    +1     
  Lines       22517    22546   +29     
=======================================
+ Hits        16902    16926   +24     
- Misses       4692     4696    +4     
- Partials      923      924    +1
Impacted Files Coverage Δ
ioctl/newcmd/hdwallet/hdwalletcreate.go 89.65% <89.65%> (ø)
db/trie/mptrie/branchnode.go 97.22% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3037d8e...52366e6. Read the comment docs.

@LuckyPigeon LuckyPigeon marked this pull request as ready for review June 24, 2022 05:12
@LuckyPigeon LuckyPigeon requested a review from a team as a code owner June 24, 2022 05:12
huof6829
huof6829 reviewed Jun 24, 2022
View reviewed changes
ioctl/newcmd/hdwallet/hdwalletcreate_test.go Show resolved Hide resolved
ioctl/newcmd/hdwallet/hdwalletcreate.go Outdated Show resolved Hide resolved
ioctl/newcmd/hdwallet/hdwalletcreate.go Outdated Show resolved Hide resolved
ioctl/newcmd/hdwallet/hdwalletcreate.go Outdated Show resolved Hide resolved
ioctl/newcmd/hdwallet/hdwalletcreate_test.go Outdated Show resolved Hide resolved
@LuckyPigeon LuckyPigeon mentioned this pull request Jun 29, 2022
Merged
11 tasks
@Liuhaai Liuhaai merged commit 38fb852 into iotexproject:master Jun 29, 2022
pocockn added a commit to pocockn/iotex-core that referenced this pull request Jul 4, 2022
@pocockn
Merge remote-tracking branch 'upstream/master'
3a229d9 
* upstream/master: (24 commits)
  account type with zero init nonce (iotexproject#3387)
  [api] Separate Server and Server Handler (iotexproject#3485)
  [ioctl] Build hdwallet derive command line into new ioctl (iotexproject#3418)
  [ioctl] Build hdwallet create command line into new ioctl (iotexproject#3470)
  [makefile] add go mod tidy (iotexproject#3471)
  [api] update chain metrics (iotexproject#3484)
  remove config.EVMNetworkID() (iotexproject#3460)
  [filedao] remove checkMasterChainDBFile() (iotexproject#3463)
  [api] add crashlog (iotexproject#3456)
  [api] Move generateBlockMeta to grpcserver.go (iotexproject#3303)
  [ioctl] Build action hash command line into new ioctl (iotexproject#3425)
  [ioctl] Build hdwallet export command line into new ioctl (iotexproject#3423)
  [ioctl] Refactor nodereward command in new ioctl (iotexproject#3416)
  [ioctl] Cleanup TestNewNodeDelegateCmd (iotexproject#3421)
  [blockchain] Remove BoltDBDaoOption (iotexproject#3465)
  remove InMemDaoOption (iotexproject#3464)
  [action] add evm london test (iotexproject#3402)
  [ioctl] create main for ioctl/newcmd (iotexproject#3296)
  [ioctl] Build block bucket command line into new ioctl (iotexproject#3386)
  [ioctl] Build hdwallet import command line into new ioctl (iotexproject#3419)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huof6829 huof6829 huof6829 approved these changes

@Liuhaai Liuhaai Liuhaai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ioctl] build hdwallet create command line into new ioctl
3 participants
@LuckyPigeon @huof6829 @Liuhaai