-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ioctl] Build block bucket command line into new ioctl #3386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3386 +/- ##
==========================================
+ Coverage 75.22% 75.29% +0.07%
==========================================
Files 238 239 +1
Lines 22057 22171 +114
==========================================
+ Hits 16592 16694 +102
- Misses 4574 4581 +7
- Partials 891 896 +5
Continue to review full report at Codecov.
|
@huof6829 iotex-core/ioctl/cmd/bc/bcbucket.go Line 162 in de09d24
|
use iotex-core/ioctl/newcmd/account/account.go Line 190 in de09d24
|
@xianhuawei |
combine getBucketByIndex and getBucketsCount similar code and form another function
@LuckyPigeon the test fails. Could you help fix it? The pr is ready to be merged. |
@Liuhaai Done! |
* upstream/master: (24 commits) account type with zero init nonce (iotexproject#3387) [api] Separate Server and Server Handler (iotexproject#3485) [ioctl] Build hdwallet derive command line into new ioctl (iotexproject#3418) [ioctl] Build hdwallet create command line into new ioctl (iotexproject#3470) [makefile] add go mod tidy (iotexproject#3471) [api] update chain metrics (iotexproject#3484) remove config.EVMNetworkID() (iotexproject#3460) [filedao] remove checkMasterChainDBFile() (iotexproject#3463) [api] add crashlog (iotexproject#3456) [api] Move generateBlockMeta to grpcserver.go (iotexproject#3303) [ioctl] Build action hash command line into new ioctl (iotexproject#3425) [ioctl] Build hdwallet export command line into new ioctl (iotexproject#3423) [ioctl] Refactor nodereward command in new ioctl (iotexproject#3416) [ioctl] Cleanup TestNewNodeDelegateCmd (iotexproject#3421) [blockchain] Remove BoltDBDaoOption (iotexproject#3465) remove InMemDaoOption (iotexproject#3464) [action] add evm london test (iotexproject#3402) [ioctl] create main for ioctl/newcmd (iotexproject#3296) [ioctl] Build block bucket command line into new ioctl (iotexproject#3386) [ioctl] Build hdwallet import command line into new ioctl (iotexproject#3419) ...
Description
Build
bcbucket
command in new ioctl, with the following note.fmt.Println
withcmd.Println
Fixes #3265
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: