[ioctl] create main for ioctl/newcmd #3296

huof6829 · 2022-04-13T15:30:20Z

Description

Create main function to test ioctl/newcmd/account. Run in command line.
make newioctl
./bin/newioctl account createadd test1

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

codecov · 2022-04-13T16:07:56Z

Codecov Report

Merging #3296 (3f2bb7a) into master (9c24171) will decrease coverage by 0.01%.
The diff coverage is 73.56%.

@@            Coverage Diff             @@
##           master    #3296      +/-   ##
==========================================
- Coverage   75.30%   75.28%   -0.02%     
==========================================
  Files         239      241       +2     
  Lines       22171    22258      +87     
==========================================
+ Hits        16696    16758      +62     
- Misses       4578     4597      +19     
- Partials      897      903       +6

Impacted Files	Coverage Δ
ioctl/newcmd/config/config.go	`63.49% <63.49%> (ø)`
ioctl/newcmd/account/account.go	`89.17% <100.00%> (+0.11%)`	⬆️
ioctl/newcmd/root.go	`100.00% <100.00%> (ø)`
consensus/scheme/rolldpos/rolldposctx.go	`73.59% <0.00%> (-0.49%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c24171...3f2bb7a. Read the comment docs.

Liuhaai · 2022-04-14T02:31:18Z

pls update the cmd in https://github.com/iotexproject/iotex-core/blob/master/Makefile

huof6829 · 2022-04-14T12:35:51Z

done:
make newioctl

tools/ioctl/newmain/ioctl.go

Makefile

ioctl/newcmd/config/cofigreset.go

ioctl/newcmd/config/cofigset.go

dustinxie · 2022-05-18T16:53:35Z

ioctl/newcmd/config/config.go

@@ -0,0 +1,155 @@
+// Copyright (c) 2022 IoTeX Foundation


these 4 new files file another PR like "add config command"

yes, just add function, but no specific implementation. this will be done after merged

ok, delete command function and create new pr for it

CoderZhi · 2022-06-13T17:14:34Z

ioctl/newcmd/config/cofig_get.go

@@ -0,0 +1,52 @@
+// Copyright (c) 2022 IoTeX Foundation


config_get.go

CoderZhi · 2022-06-13T17:16:07Z

ioctl/newcmd/config/cofig_reset.go

@@ -0,0 +1,42 @@
+// Copyright (c) 2022 IoTeX Foundation


config_reset.go

CoderZhi · 2022-06-13T17:16:13Z

ioctl/newcmd/config/cofig_set.go

@@ -0,0 +1,52 @@
+// Copyright (c) 2022 IoTeX Foundation


config_set.go

CoderZhi · 2022-06-13T17:48:57Z

tools/newioctl/ioctl.go

+	rootCmd := newcmd.NewIoctl(client)
+	if err := rootCmd.Execute(); err != nil {


if err := newcmd.NewIoctl(client).Execute(); err != nil {

CoderZhi · 2022-06-13T17:49:23Z

tools/newxctl/xctl.go

+	rootCmd := newcmd.NewXctl(client)
+	if err := rootCmd.Execute(); err != nil {


if err := newcmd.NewXctl(client).Execute(); err != nil {

CoderZhi · 2022-06-13T17:50:52Z

ioctl/newcmd/config/config.go

+}
+
+// InitConfig load config data from default config file
+func InitConfig() (config.Config, string) {


return error

no need to return err. because if err!=nil, panic.

Multiple places return error

the error handling logic is the same, panic

Thus, returning the error and handle it in the caller side is a better solution

I know, Thanks.

CoderZhi · 2022-06-13T17:52:39Z

ioctl/newcmd/config/config.go

+	if err != nil {
+		if os.IsNotExist(err) {
+			err = info.reset() // Config file doesn't exist
+		}
+		if err != nil {
+			log.L().Panic(err.Error())
+		}
+	}


the logic is not clear

CoderZhi · 2022-06-13T17:56:08Z

ioctl/newcmd/config/config.go

+)
+
+// Info contains the information of config file
+type Info struct {


private struct

CoderZhi · 2022-06-13T17:56:50Z

ioctl/newcmd/config/config.go

@@ -0,0 +1,155 @@
+// Copyright (c) 2022 IoTeX Foundation


CoderZhi · 2022-06-21T16:53:14Z

ioctl/newcmd/config/config.go

+
+	// Load or reset config file
+	info.readConfig, err = config.LoadConfig()
+	if err != nil && os.IsNotExist(err) {


https://pkg.go.dev/os#IsNotExist

* create main for ioctl/newcmd

* [ioctl] build hdwallet derive command line into new ioctl * inline DeriveKey * adjust order * revert DeriveKey inline * create ExportHdwallet client interface combine hdwalletderive & hdwalletexport code and create ExportHdwallet client interface * [ioctl] create main for ioctl/newcmd (#3296) * create main for ioctl/newcmd * change return type of HdwalletMnemonic * refactor unit test to cover the modification * refactor unit test to cover the modification * fix commit * fix commit Co-authored-by: huofei <[email protected]> Co-authored-by: CoderZhi <[email protected]>

* upstream/master: (24 commits) account type with zero init nonce (iotexproject#3387) [api] Separate Server and Server Handler (iotexproject#3485) [ioctl] Build hdwallet derive command line into new ioctl (iotexproject#3418) [ioctl] Build hdwallet create command line into new ioctl (iotexproject#3470) [makefile] add go mod tidy (iotexproject#3471) [api] update chain metrics (iotexproject#3484) remove config.EVMNetworkID() (iotexproject#3460) [filedao] remove checkMasterChainDBFile() (iotexproject#3463) [api] add crashlog (iotexproject#3456) [api] Move generateBlockMeta to grpcserver.go (iotexproject#3303) [ioctl] Build action hash command line into new ioctl (iotexproject#3425) [ioctl] Build hdwallet export command line into new ioctl (iotexproject#3423) [ioctl] Refactor nodereward command in new ioctl (iotexproject#3416) [ioctl] Cleanup TestNewNodeDelegateCmd (iotexproject#3421) [blockchain] Remove BoltDBDaoOption (iotexproject#3465) remove InMemDaoOption (iotexproject#3464) [action] add evm london test (iotexproject#3402) [ioctl] create main for ioctl/newcmd (iotexproject#3296) [ioctl] Build block bucket command line into new ioctl (iotexproject#3386) [ioctl] Build hdwallet import command line into new ioctl (iotexproject#3419) ...

create main for ioctl/newcmd

9e53445

huof6829 requested a review from a team as a code owner April 13, 2022 15:30

huof6829 added 2 commits April 13, 2022 23:39

add comment

a03f342

add comment

f27e99c

huof6829 closed this Apr 14, 2022

huof6829 reopened this Apr 14, 2022

huof6829 added the pending label Apr 15, 2022

huof6829 added 4 commits April 15, 2022 13:50

Merge branch 'master' into dev_ioctl_main

c09614c

add make newioctl

ca91803

Merge branch 'master' into dev_ioctl_main

d2a241f

use SelectTranslation

9383cf3

huof6829 removed the pending label Apr 22, 2022

Liuhaai reviewed Apr 23, 2022

View reviewed changes

tools/ioctl/newmain/ioctl.go Outdated Show resolved Hide resolved

Makefile Show resolved Hide resolved

huof6829 added 2 commits April 24, 2022 12:21

Merge branch 'master' into dev_ioctl_main

75bdd5a

mkdir tools/newioctl

70e895c

Liuhaai approved these changes Apr 25, 2022

View reviewed changes

huof6829 added 11 commits April 26, 2022 23:05

Merge branch 'master' into dev_ioctl_main

748931a

Merge branch 'master' into dev_ioctl_main

381522e

Merge branch 'master' into dev_ioctl_main

d8a0e50

Merge branch 'master' into dev_ioctl_main

b843f92

Merge branch 'master' into dev_ioctl_main

b162956

Merge branch 'iotexproject:master' into dev_ioctl_main

d923f3d

Merge branch 'master' into dev_ioctl_main

968902b

Merge branch 'master' into dev_ioctl_main

a44f6f3

Merge branch 'master' into dev_ioctl_main

1b3c14b

Merge branch 'master' into dev_ioctl_main

59e6d42

Merge branch 'master' into dev_ioctl_main

233c6b6

dustinxie reviewed May 18, 2022

View reviewed changes

ioctl/newcmd/config/cofigreset.go Outdated Show resolved Hide resolved

dustinxie reviewed May 18, 2022

View reviewed changes

ioctl/newcmd/config/cofigset.go Outdated Show resolved Hide resolved

dustinxie reviewed May 18, 2022

View reviewed changes

huof6829 added 9 commits May 23, 2022 10:01

Merge branch 'master' into dev_ioctl_main

e6912a1

Merge branch 'master' into dev_ioctl_main

24f9fb9

Merge branch 'master' into dev_ioctl_main

45172d1

Merge branch 'master' into dev_ioctl_main

3d59975

add _ in file name

bfce58b

Merge branch 'master' into dev_ioctl_main

4c24ee8

Merge branch 'master' into dev_ioctl_main

fd20e2b

Merge branch 'master' into dev_ioctl_main

9a49780

Merge branch 'master' into dev_ioctl_main

7219bf2

CoderZhi reviewed Jun 13, 2022

View reviewed changes

huof6829 added 9 commits June 14, 2022 16:36

Merge branch 'master' into dev_ioctl_main

23254d6

modify filename

bb11a7f

return err for InitConfig()

594fb24

delete sub command function for new pr creating

461b5bc

Merge branch 'master' into dev_ioctl_main

bc0b05c

Merge branch 'master' into dev_ioctl_main

bc68fed

Merge branch 'master' into dev_ioctl_main

ed3f8fc

Merge branch 'master' into dev_ioctl_main

3d915ba

modify InitConfig return value

4d7d30e

CoderZhi approved these changes Jun 21, 2022

View reviewed changes

huof6829 added 2 commits June 22, 2022 13:26

move panic from InitConfig() inside to caller aside

9a75119

add test

3f2bb7a

huof6829 merged commit 1f10a0f into iotexproject:master Jun 23, 2022

huof6829 deleted the dev_ioctl_main branch June 23, 2022 03:49

LuckyPigeon pushed a commit to LuckyPigeon/iotex-core that referenced this pull request Jun 23, 2022

[ioctl] create main for ioctl/newcmd (iotexproject#3296)

a56fa05

* create main for ioctl/newcmd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ioctl] create main for ioctl/newcmd #3296

[ioctl] create main for ioctl/newcmd #3296

huof6829 commented Apr 13, 2022 •

edited

Loading

codecov bot commented Apr 13, 2022 •

edited

Loading

Liuhaai commented Apr 14, 2022

huof6829 commented Apr 14, 2022 •

edited

Loading

dustinxie May 18, 2022

huof6829 May 26, 2022

CoderZhi Jun 13, 2022

huof6829 Jun 14, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 13, 2022

huof6829 Jun 20, 2022

CoderZhi Jun 21, 2022

huof6829 Jun 22, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 13, 2022

CoderZhi Jun 21, 2022

		rootCmd := newcmd.NewIoctl(client)
		if err := rootCmd.Execute(); err != nil {

		rootCmd := newcmd.NewXctl(client)
		if err := rootCmd.Execute(); err != nil {

[ioctl] create main for ioctl/newcmd #3296

[ioctl] create main for ioctl/newcmd #3296

Conversation

huof6829 commented Apr 13, 2022 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

codecov bot commented Apr 13, 2022 • edited Loading

Codecov Report

Liuhaai commented Apr 14, 2022

huof6829 commented Apr 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huof6829 commented Apr 13, 2022 •

edited

Loading

codecov bot commented Apr 13, 2022 •

edited

Loading

huof6829 commented Apr 14, 2022 •

edited

Loading