[api] Move generateBlockMeta to grpcserver.go

[LuckyPigeon]

Description

Move generateBlockMeta to grpcserver.go

Fixes # 3271

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• TestGrpcServer_GetBlockMetasIntegrity
• TestGrpcServer_GetBlockMetaIntegrity

Test Configuration:

• Firmware version: Ubuntu 21.04
• Hardware:
• Toolchain:
• SDK:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[codecov]

Codecov Report

Merging #3303 (95f0364) into master (fd6561a) will increase coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
+ Coverage   75.12%   75.13%   +0.01%     
==========================================
  Files         243      243              
  Lines       22503    22506       +3     
==========================================
+ Hits        16906    16911       +5     
+ Misses       4676     4673       -3     
- Partials      921      922       +1     

Impacted Files	Coverage Δ
api/grpcserver.go	79.62% <93.75%> (+0.99%)	⬆️
api/coreservice.go	67.65% <100.00%> (-0.82%)	⬇️
consensus/scheme/rolldpos/rolldposctx.go	74.08% <0.00%> (+0.48%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6561a...95f0364. Read the comment docs.

[Liuhaai]

this pr is to be reviewed after #3298 is merged

[Liuhaai]

The goal of the issue is to remove BlockMeta from coreservice, which might involve numbers of refactor work. Do you want to continue working on this issue? @LuckyPigeon

[LuckyPigeon]

@Liuhaai
Sure!

[Liuhaai]

@Liuhaai Sure!

you could remove the pending label when the pr is ready for review

[LuckyPigeon]

@Liuhaai
Seems generateBlockMeta has already moved to grpcserver.go.
BTY, I have no authority to remove pending tag.

[Liuhaai]

@Liuhaai Seems generateBlockMeta has already moved to grpcserver.go. BTY, I have no authority to remove pending tag.

could you give a link to generateBlockMeta?

[LuckyPigeon]

Here you go

iotex-core/api/grpcserver.go

Line 727 in 682bad6

func generateBlockMeta(blk *block.Block) *iotextypes.BlockMeta {

[Liuhaai]

remove BlockMeta from coreservice

BlockMeta in coreservice should be removed to solve this issue as well

[LuckyPigeon]

Both BlockMetas and BlockMetaByHash seems necessary tocoreservice.go, and they both rely on generateBlockMeta, so I think there might be no func to remove.
Unless we need to combine them with generateBlockMeta.

[Liuhaai]

Both BlockMetas and BlockMetaByHash seems necessary tocoreservice.go, and they both rely on generateBlockMeta, so I think there might be no func to remove. Unless we need to combine them with generateBlockMeta.

ok, thx for the pr. I will complete remaining work in the following pr.