fix: tag-prefix passed as a string #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
approved these changes
Jan 25, 2023
thibault-martinez
approved these changes
Jan 25, 2023
amadeu2
added a commit
to amadeu2/wallet.rs
that referenced
this pull request
Jan 26, 2023
* develop: (70 commits) Feat: rocksdb as optional storage (iotaledger#1728) apply version updates (iotaledger#1755) Make the voting output mandatory in input selection for voting functions (iotaledger#1753) fix: tag-prefix passed as a string (iotaledger#1752) apply version updates (iotaledger#1750) Use OutputMetadataDto (iotaledger#1749) feat: create arm64 builds (iotaledger#1751) Allow voting output in inputs if required (iotaledger#1748) apply version updates (iotaledger#1745) Use new Input Selection (iotaledger#1744) Fix dependabot audit (iotaledger#1747) Add Python integration guide with IOTA and Shimmer (iotaledger#1743) Change sync options (iotaledger#1737) Add inputs to transaction to align incoming transactions (iotaledger#1722) apply version updates (iotaledger#1729) Send requests in parallel, check participation output unlock conditions (iotaledger#1740) Move all participation methods from the AccountManager to the Account (iotaledger#1736) Limit max parallel request in request_incoming_transaction_data() (iotaledger#1720) Remove useless old code (iotaledger#1731) chore: add more alignment for participation code (iotaledger#1727) ... Signed-off-by: Amadeo Marchioni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Prebuild-install couldn't find the correct package, since it didn't add the prefix when looking for the github release.
https://github.com/iotaledger/firefly/actions/runs/3997595702/jobs/6859134518#step:17:186
In the action above it looks for: https://github.com/iotaledger/wallet.rs/releases/download/v2.0.3-rc.15/wallet-v2.0.3-rc.15-napi-v6-win32-x64.tar.gz
Whereas the actual release is at: https://github.com/iotaledger/wallet.rs/releases/download/nodejs-binding-v2.0.3-rc.15/wallet-v2.0.3-rc.15-napi-v6-linux-x64.tar.gz
**note the
nodejs-binding-prefixType of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Tested
npm run installwith a clean .npm cache and noprebuildfolder in the bindings on Ubuntu 22.04.Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.