Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all participation methods from the AccountManager to the Account #1736

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

Thoralf-M
Copy link
Member

Description of change

Move all participation methods from the AccountManager to the Account

Links to any relevant issues

Fixes #1678

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M Thoralf-M requested a review from Tuditi January 17, 2023 17:24
kwek20
kwek20 previously approved these changes Jan 18, 2023
CHANGELOG.md Show resolved Hide resolved
@Thoralf-M Thoralf-M merged commit a4f897e into iotaledger:develop Jan 18, 2023
@Thoralf-M Thoralf-M deleted the mv-participation-to-account branch January 18, 2023 17:35
amadeu2 added a commit to amadeu2/wallet.rs that referenced this pull request Jan 26, 2023
* develop: (70 commits)
  Feat: rocksdb as optional storage (iotaledger#1728)
  apply version updates (iotaledger#1755)
  Make the voting output mandatory in input selection for voting functions (iotaledger#1753)
  fix: tag-prefix passed as a string (iotaledger#1752)
  apply version updates (iotaledger#1750)
  Use OutputMetadataDto (iotaledger#1749)
  feat: create arm64 builds (iotaledger#1751)
  Allow voting output in inputs if required (iotaledger#1748)
  apply version updates (iotaledger#1745)
  Use new Input Selection (iotaledger#1744)
  Fix dependabot audit (iotaledger#1747)
  Add Python integration guide with IOTA and Shimmer (iotaledger#1743)
  Change sync options (iotaledger#1737)
  Add inputs to transaction to align incoming transactions (iotaledger#1722)
  apply version updates (iotaledger#1729)
  Send requests in parallel, check participation output unlock conditions (iotaledger#1740)
  Move all participation methods from the AccountManager to the Account (iotaledger#1736)
  Limit max parallel request in request_incoming_transaction_data() (iotaledger#1720)
  Remove useless old code (iotaledger#1731)
  chore: add more alignment for participation code (iotaledger#1727)
  ...

Signed-off-by: Amadeo Marchioni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Move the participation API calls to the Account context
3 participants