Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: rocksdb as optional storage #1728

Merged
merged 15 commits into from
Jan 25, 2023

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Jan 13, 2023

I would leave out rocksdb as default completely, but some tests rely on data storage persistence.
An option is to make the Memory hashmap global, but i dont think thats worth the trouble

This is a pre for wasm storage in the browser (LocalStorage)

Cargo.toml Show resolved Hide resolved
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clippy

Thoralf-M
Thoralf-M previously approved these changes Jan 24, 2023
Thoralf-M
Thoralf-M previously approved these changes Jan 24, 2023
@thibault-martinez thibault-martinez merged commit 3a9800e into iotaledger:develop Jan 25, 2023
amadeu2 added a commit to amadeu2/wallet.rs that referenced this pull request Jan 26, 2023
* develop: (70 commits)
  Feat: rocksdb as optional storage (iotaledger#1728)
  apply version updates (iotaledger#1755)
  Make the voting output mandatory in input selection for voting functions (iotaledger#1753)
  fix: tag-prefix passed as a string (iotaledger#1752)
  apply version updates (iotaledger#1750)
  Use OutputMetadataDto (iotaledger#1749)
  feat: create arm64 builds (iotaledger#1751)
  Allow voting output in inputs if required (iotaledger#1748)
  apply version updates (iotaledger#1745)
  Use new Input Selection (iotaledger#1744)
  Fix dependabot audit (iotaledger#1747)
  Add Python integration guide with IOTA and Shimmer (iotaledger#1743)
  Change sync options (iotaledger#1737)
  Add inputs to transaction to align incoming transactions (iotaledger#1722)
  apply version updates (iotaledger#1729)
  Send requests in parallel, check participation output unlock conditions (iotaledger#1740)
  Move all participation methods from the AccountManager to the Account (iotaledger#1736)
  Limit max parallel request in request_incoming_transaction_data() (iotaledger#1720)
  Remove useless old code (iotaledger#1731)
  chore: add more alignment for participation code (iotaledger#1727)
  ...

Signed-off-by: Amadeo Marchioni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants