Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependabot audit #1747

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix dependabot audit #1747

merged 1 commit into from
Jan 23, 2023

Conversation

thibault-martinez
Copy link
Member

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

kwek20
kwek20 reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated cargo locks in bindings but not in our main crate? is that intentional?

@thibault-martinez
Copy link
Member Author

We updated cargo locks in bindings but not in our main crate? is that intentional?

At the moment it's git ignored so I can't update it. Whether it should be ignored or not is another question...

@Thoralf-M Thoralf-M merged commit 45df383 into iotaledger:develop Jan 23, 2023
@thibault-martinez thibault-martinez deleted the dependabot-audit branch January 23, 2023 12:28
amadeu2 added a commit to amadeu2/wallet.rs that referenced this pull request Jan 26, 2023
@amadeu2
Merge branch 'develop' into feat/capacitor-iota-wallet-plugin
22c7d7e 
* develop: (70 commits)
  Feat: rocksdb as optional storage (iotaledger#1728)
  apply version updates (iotaledger#1755)
  Make the voting output mandatory in input selection for voting functions (iotaledger#1753)
  fix: tag-prefix passed as a string (iotaledger#1752)
  apply version updates (iotaledger#1750)
  Use OutputMetadataDto (iotaledger#1749)
  feat: create arm64 builds (iotaledger#1751)
  Allow voting output in inputs if required (iotaledger#1748)
  apply version updates (iotaledger#1745)
  Use new Input Selection (iotaledger#1744)
  Fix dependabot audit (iotaledger#1747)
  Add Python integration guide with IOTA and Shimmer (iotaledger#1743)
  Change sync options (iotaledger#1737)
  Add inputs to transaction to align incoming transactions (iotaledger#1722)
  apply version updates (iotaledger#1729)
  Send requests in parallel, check participation output unlock conditions (iotaledger#1740)
  Move all participation methods from the AccountManager to the Account (iotaledger#1736)
  Limit max parallel request in request_incoming_transaction_data() (iotaledger#1720)
  Remove useless old code (iotaledger#1731)
  chore: add more alignment for participation code (iotaledger#1727)
  ...

Signed-off-by: Amadeo Marchioni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thibault-martinez @kwek20 @samuel-rufi @Thoralf-M