Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD] Remove tests migrated to llvm-test-suite #2611

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

vladimirlaz
Copy link
Contributor

@vladimirlaz vladimirlaz commented Oct 8, 2020

The tests have been submitted in scope of intel/llvm-test-suite#29

@vladimirlaz vladimirlaz requested a review from a team as a code owner October 8, 2020 11:34
@bader bader added the esimd Explicit SIMD feature label Oct 8, 2020
@bader bader changed the title [SYCL] Remove tests migrated to llvm-test-suite [SYCL][ESIMD] Remove tests migrated to llvm-test-suite Oct 8, 2020
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not sure if we should leave a README file or remove it together with the tests.

@kbobrovs
Copy link
Contributor

kbobrovs commented Oct 8, 2020

@vladimirlaz, @bader - will ESIMD tests in the new place still be run as part of CI testing (buildbot/sycl-*-64-pr)?

@vladimirlaz
Copy link
Contributor Author

@vladimirlaz, @bader - will ESIMD tests in the new place still be run as part of CI testing (buildbot/sycl-*-64-pr)?

They are run as part of post-commit and Jenkins/Summary (when /summary:run comment is added). Potentially we can request executing them for every pre-commit testing. But it may be too expensive once more heavy tests will be added to llvm-test-suite.

@kbobrovs
Copy link
Contributor

kbobrovs commented Oct 8, 2020

We really need ESIMD tests to run as a part of pre-commit CI, at least several of them.

@vladimirlaz
Copy link
Contributor Author

https://github.com/intel/llvm/tree/sycl/sycl/test/esimd are still preserved in pre-checkin.

@bader bader merged commit 69825ee into intel:sycl Oct 8, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 14, 2020
* sycl: (566 commits)
  [SYCL] Fix explicit copy operation for host device (intel#2627)
  [SYCL] Fix initialization issue on Windows (intel#2632)
  [SYCL][CUDA] Disable image_write test on CUDA devices (intel#2630)
  [SYCL] Removes any knowledge of specific memory advices from PI API. (intel#2607)
  [BuildBot] Uplift GPU RT version for Linux to 20.40.18075 (intel#2626)
  [SYCL] Wrap complex global objects to control lifetime (intel#2516)
  [SYCL][CUDA] Image Basic Test (intel#1970)
  [SYCL] Align get_info<info::device::version>() with the SYCL spec (intel#2507)
  [Driver][SYCL] Correct optimization disabling option for gen (intel#2622)
  [SYCL][LIT] Add deleter func for test in buffer.cpp to avoid potential SegFault (intel#2616)
  [SYCL] Remove half type alias causing name conflicts (intel#2624)
  [BuildBot] OpenCL CPU/FPGAEMU driver uplift (intel#2620)
  [SYCL][Doc] Add overview of kernel-program caching (intel#2514)
  [SYCL] Remove two-input sub-group shuffles (intel#2614)
  [SYCL] Add support for new spelling of FPGA kernel attribute scheduler_target_fmax_mhz (intel#2618)
  [SYCL] Align image class constructors with the SYCL spec (intel#2603)
  [SYCL] Remove tests migrated to llvm-test-suite (intel#2611)
  [SYCL][NFC] Fix dependency for SYCL add_sycl_executable macro (intel#2613)
  [SYCL][PI][L0] Update environment variables from LEVEL0 to LEVEL_ZERO (intel#2612)
  [SYCL] Add KernelNameTypeVisitor validation check (intel#2596)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esimd Explicit SIMD feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants