Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Doc] Add overview of kernel-program caching #2514

Merged
merged 12 commits into from
Oct 9, 2020

Conversation

s-kanaev
Copy link
Contributor

@s-kanaev s-kanaev commented Sep 22, 2020

No description provided.

sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
@s-kanaev s-kanaev changed the title [Doc] Add overview of kernel-program caching [SYCL][Doc] Add overview of kernel-program caching Sep 23, 2020
Signed-off-by: Sergey Kanaev <[email protected]>
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is going to break our automation. @s-kanaev please update https://github.com/intel/llvm/blob/sycl/sycl/doc/index.rst accordingly. Also I'm not sure if HTML tags are going to work with Sphinx. Please, try building documentation locally. You can figure out how it's done in CI from https://github.com/intel/llvm/blob/sycl/.github/workflows/gh_pages.yml

@s-kanaev
Copy link
Contributor Author

@alexbatashev I've built documentation with docs-sycl-html target. The file looks good and the links are OK in generated html. The new file is added to table of contents.

Signed-off-by: Sergey Kanaev <[email protected]>
alexbatashev
alexbatashev previously approved these changes Sep 24, 2020
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.rst LGTM

Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First portion, reviewed until Thread safety.

sycl/doc/KernelProgramCache.md Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
Signed-off-by: Sergey Kanaev <[email protected]>
Signed-off-by: Sergey Kanaev <[email protected]>
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sergey Kanaev <[email protected]>
romanovvlad
romanovvlad previously approved these changes Oct 6, 2020
@pvchupin
Copy link
Contributor

pvchupin commented Oct 6, 2020

@kbobrovs please review

sycl/doc/KernelProgramCache.md Outdated Show resolved Hide resolved
Signed-off-by: Sergey Kanaev <[email protected]>
@s-kanaev s-kanaev requested a review from kbobrovs October 9, 2020 13:29
@pvchupin pvchupin dismissed kbobrovs’s stale review October 9, 2020 17:10

Comments addressed

@pvchupin pvchupin merged commit 5947cde into intel:sycl Oct 9, 2020
@s-kanaev s-kanaev deleted the private/s-kanaev/kp-cache branch October 12, 2020 11:32
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 14, 2020
* sycl: (566 commits)
  [SYCL] Fix explicit copy operation for host device (intel#2627)
  [SYCL] Fix initialization issue on Windows (intel#2632)
  [SYCL][CUDA] Disable image_write test on CUDA devices (intel#2630)
  [SYCL] Removes any knowledge of specific memory advices from PI API. (intel#2607)
  [BuildBot] Uplift GPU RT version for Linux to 20.40.18075 (intel#2626)
  [SYCL] Wrap complex global objects to control lifetime (intel#2516)
  [SYCL][CUDA] Image Basic Test (intel#1970)
  [SYCL] Align get_info<info::device::version>() with the SYCL spec (intel#2507)
  [Driver][SYCL] Correct optimization disabling option for gen (intel#2622)
  [SYCL][LIT] Add deleter func for test in buffer.cpp to avoid potential SegFault (intel#2616)
  [SYCL] Remove half type alias causing name conflicts (intel#2624)
  [BuildBot] OpenCL CPU/FPGAEMU driver uplift (intel#2620)
  [SYCL][Doc] Add overview of kernel-program caching (intel#2514)
  [SYCL] Remove two-input sub-group shuffles (intel#2614)
  [SYCL] Add support for new spelling of FPGA kernel attribute scheduler_target_fmax_mhz (intel#2618)
  [SYCL] Align image class constructors with the SYCL spec (intel#2603)
  [SYCL] Remove tests migrated to llvm-test-suite (intel#2611)
  [SYCL][NFC] Fix dependency for SYCL add_sycl_executable macro (intel#2613)
  [SYCL][PI][L0] Update environment variables from LEVEL0 to LEVEL_ZERO (intel#2612)
  [SYCL] Add KernelNameTypeVisitor validation check (intel#2596)
  ...
iclsrc pushed a commit that referenced this pull request Apr 25, 2024
In preparation for LLVM's deprecation of Instruction constructors and
Create methods that accept `Instruction` pointers, upgrade call sites
to pass an iterator instead of an `Instruction` pointer.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@3c1ff53d6202f02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants