Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][CUDA] Image Basic Test #1970

Merged
merged 13 commits into from
Oct 12, 2020
Merged

Conversation

nyalloc
Copy link
Contributor

@nyalloc nyalloc commented Jun 24, 2020

Provides new generic testing for SYCL image functionality.

@nyalloc nyalloc requested a review from a team as a code owner June 24, 2020 10:45
@bader bader added the cuda CUDA back-end label Jun 24, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] Implemented basic_tests/image [SYCL][CUDA] Implemented basic_tests/image Jun 24, 2020
sycl/test/basic_tests/image/image_write.cpp Outdated Show resolved Hide resolved
sycl/test/basic_tests/image/image_write.cpp Outdated Show resolved Hide resolved
sycl/test/basic_tests/image/image_write.cpp Outdated Show resolved Hide resolved
@nyalloc nyalloc changed the title [SYCL][CUDA] Implemented basic_tests/image [SYCL][CUDA] Image Basic Test Jun 26, 2020
@nyalloc nyalloc changed the title [SYCL][CUDA] Image Basic Test [SYCL][CUDA][WIP] Image Basic Test Jun 26, 2020
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but I'd like @vladimirlaz to approve

@nyalloc nyalloc force-pushed the stuart/basic_tests/image branch 2 times, most recently from 64af5cc to 8e63688 Compare June 29, 2020 17:43
alexbatashev
alexbatashev previously approved these changes Jul 7, 2020
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nyalloc nyalloc changed the title [SYCL][CUDA][WIP] Image Basic Test [WIP][DONOTMERGE][SYCL][CUDA]Image Basic Test Jul 9, 2020
@nyalloc nyalloc changed the title [WIP][DONOTMERGE][SYCL][CUDA]Image Basic Test [WIP][DONOTMERGE][SYCL][CUDA] Image Basic Test Jul 9, 2020
@nyalloc nyalloc changed the title [WIP][DONOTMERGE][SYCL][CUDA] Image Basic Test [SYCL][CUDA] Image Basic Test Jul 10, 2020
bader
bader previously approved these changes Jul 10, 2020
@bader bader requested a review from alexbatashev July 10, 2020 16:53
alexbatashev
alexbatashev previously approved these changes Jul 10, 2020
@bader bader dismissed stale reviews from alexbatashev and themself via 8890d21 July 12, 2020 07:08
alexbatashev
alexbatashev previously approved these changes Jul 14, 2020
bader
bader previously approved these changes Jul 14, 2020
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to start testing.

sycl/test/basic_tests/image_accessor_readsampler.cpp Outdated Show resolved Hide resolved
@@ -1,4 +1,5 @@
// UNSUPPORTED: cuda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this test still failing on CUDA? If so could you provide more detail description for TODO?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from line 2: // CUDA cannot support SYCL 1.2.1 images.
Would you like to see anything else?

sycl/test/basic_tests/image/image_write.cpp Outdated Show resolved Hide resolved
bader
bader previously approved these changes Oct 12, 2020
bader
bader previously approved these changes Oct 12, 2020
@bader
Copy link
Contributor

bader commented Oct 12, 2020

@alexbatashev, @vladimirlaz, please, take a look.

@bader bader merged commit 304067c into intel:sycl Oct 12, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Oct 14, 2020
* sycl: (566 commits)
  [SYCL] Fix explicit copy operation for host device (intel#2627)
  [SYCL] Fix initialization issue on Windows (intel#2632)
  [SYCL][CUDA] Disable image_write test on CUDA devices (intel#2630)
  [SYCL] Removes any knowledge of specific memory advices from PI API. (intel#2607)
  [BuildBot] Uplift GPU RT version for Linux to 20.40.18075 (intel#2626)
  [SYCL] Wrap complex global objects to control lifetime (intel#2516)
  [SYCL][CUDA] Image Basic Test (intel#1970)
  [SYCL] Align get_info<info::device::version>() with the SYCL spec (intel#2507)
  [Driver][SYCL] Correct optimization disabling option for gen (intel#2622)
  [SYCL][LIT] Add deleter func for test in buffer.cpp to avoid potential SegFault (intel#2616)
  [SYCL] Remove half type alias causing name conflicts (intel#2624)
  [BuildBot] OpenCL CPU/FPGAEMU driver uplift (intel#2620)
  [SYCL][Doc] Add overview of kernel-program caching (intel#2514)
  [SYCL] Remove two-input sub-group shuffles (intel#2614)
  [SYCL] Add support for new spelling of FPGA kernel attribute scheduler_target_fmax_mhz (intel#2618)
  [SYCL] Align image class constructors with the SYCL spec (intel#2603)
  [SYCL] Remove tests migrated to llvm-test-suite (intel#2611)
  [SYCL][NFC] Fix dependency for SYCL add_sycl_executable macro (intel#2613)
  [SYCL][PI][L0] Update environment variables from LEVEL0 to LEVEL_ZERO (intel#2612)
  [SYCL] Add KernelNameTypeVisitor validation check (intel#2596)
  ...
againull pushed a commit to againull/llvm that referenced this pull request Apr 25, 2023
againull pushed a commit to againull/llvm that referenced this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants