[SYCL] Add KernelNameTypeVisitor validation check #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srividya-sundaram
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
Fznamznon
reviewed
Oct 6, 2020
Fznamznon
reviewed
Oct 8, 2020
Co-authored-by: Mariya Podchishchaeva <[email protected]>
Fznamznon
previously approved these changes
Oct 8, 2020
Fznamznon
approved these changes
Oct 8, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Oct 14, 2020
* sycl: (566 commits) [SYCL] Fix explicit copy operation for host device (intel#2627) [SYCL] Fix initialization issue on Windows (intel#2632) [SYCL][CUDA] Disable image_write test on CUDA devices (intel#2630) [SYCL] Removes any knowledge of specific memory advices from PI API. (intel#2607) [BuildBot] Uplift GPU RT version for Linux to 20.40.18075 (intel#2626) [SYCL] Wrap complex global objects to control lifetime (intel#2516) [SYCL][CUDA] Image Basic Test (intel#1970) [SYCL] Align get_info<info::device::version>() with the SYCL spec (intel#2507) [Driver][SYCL] Correct optimization disabling option for gen (intel#2622) [SYCL][LIT] Add deleter func for test in buffer.cpp to avoid potential SegFault (intel#2616) [SYCL] Remove half type alias causing name conflicts (intel#2624) [BuildBot] OpenCL CPU/FPGAEMU driver uplift (intel#2620) [SYCL][Doc] Add overview of kernel-program caching (intel#2514) [SYCL] Remove two-input sub-group shuffles (intel#2614) [SYCL] Add support for new spelling of FPGA kernel attribute scheduler_target_fmax_mhz (intel#2618) [SYCL] Align image class constructors with the SYCL spec (intel#2603) [SYCL] Remove tests migrated to llvm-test-suite (intel#2611) [SYCL][NFC] Fix dependency for SYCL add_sycl_executable macro (intel#2613) [SYCL][PI][L0] Update environment variables from LEVEL0 to LEVEL_ZERO (intel#2612) [SYCL] Add KernelNameTypeVisitor validation check (intel#2596) ...
jsji
pushed a commit
that referenced
this pull request
Jun 27, 2024
Make code clearer and check for exact number of operands. Signed-off-by: Lu, John <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@cd4eaf69744a413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a follow-up to this PR
It sets the kernel invocation function invalid, if the KernelNameTypeVisitor fails validating the kernel name type.