Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix getDeviceFromHandler declarations #1626

Merged
merged 1 commit into from
May 1, 2020
Merged

[SYCL] Fix getDeviceFromHandler declarations #1626

merged 1 commit into from
May 1, 2020

Conversation

alexbatashev
Copy link
Contributor

Signed-off-by: Alexander Batashev [email protected]

@alexbatashev alexbatashev requested a review from a team as a code owner May 1, 2020 12:39
bader
bader approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@bader bader left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing plan?
I'm okay if you verified that it fixes build of sycl-ls app locally and rely on a new LIT test added with #1583 to cover this regression in automation.

@alexbatashev
Copy link
Contributor Author

Testing plan?
I'm okay if you verified that it fixes build of sycl-ls app locally and rely on a new LIT test added with #1583 to cover this regression in automation.

Yes, I tested it locally and build is fixed. However, I don't think testing in #1583 is sufficient. I think a more correct way would be to force -Werror for all LITs. For example, this particular error would have been caught by our testing if any of the following tests had been built with -Werror:

basic_tests/image_accessor_readsampler.cpp
basic_tests/image_accessor_readwrite.cpp
basic_tests/image_accessor_readwrite_half.cpp

This is, however, a broad task, and I don't want to block #1575.

@bader
Copy link
Contributor

bader commented May 1, 2020

Can we start with one test enabling -Werror to cover this regression?

@bader bader merged commit a61d2c7 into intel:sycl May 1, 2020
@bader
Copy link
Contributor

bader commented May 1, 2020

Let's use #1575 as short-term testing solution and implement long-term plan separately.

alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request May 6, 2020
Merge remote-tracking branch 'origin/sycl' into private/abatashe/user…
b952a76 
…_docs

* origin/sycl: (6482 commits)
  [SYCL][NFC] Clean formatting in Markdown documents (intel#1635)
  [SYCL][Doc] Remove obsolete parens from README (intel#1637)
  [SYCL] Fix failing ABI tests when LLVM_LIBDIR_SUFFIX is set (intel#1605)
  [SYCL] Fix warnings in libdevice (intel#1630)
  [SYCL][CUDA] Triage and clean LIT (intel#1620)
  [SYCL][NFC] Fix GCC 8 compilation warnings (intel#1631)
  [SYCL] Minor fixes in LowerWGScope
  [SYCL] PI: correct default interoperability plugin selection
  [SYCL] Add faster reduction implementations using atomic or/and intel::reduce() (intel#1615)
  [SYCL] Add sycl-ls utility for listing devices discovered/selected by SYCL RT (intel#1575)
  [SYCL] Fix getDeviceFromHandler declarations (intel#1626)
  [SPIR-V] Correct/improve declaration of SPIR-V builtins (intel#1519)
  [SYCL][USM] Improve USM allocator test and fix improper behavior. (intel#1538)
  [SYCL] Fix failing ABI LITs (intel#1622)
  [SYCL] Add support for MSVC internal math functions in device library (intel#1441)
  [SYCL] Add runtime library versioning (intel#1604)
  [SYCL] Check weak symbols in ABI dumps (intel#1609)
  [NFC][SYCL] Improve kernel metadata test (intel#1610)
  Revert "[SYCL] XFAIL LIT test due to duplicate diagnostic" (intel#1460)
  [SYCL] Move the reduction command group funcs out of handler.hpp (intel#1602)
  ...
@alexbatashev alexbatashev deleted the fix_get_device_from_handler branch July 28, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@bader bader bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbatashev @bader @v-klochkov