Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Check weak symbols in ABI dumps #1609

Merged

Conversation

alexbatashev
Copy link
Contributor

Signed-off-by: Alexander Batashev [email protected]

Alexander Batashev added 2 commits April 29, 2020 13:09
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
@bader bader merged commit edc87b2 into intel:sycl Apr 30, 2020
@bader
Copy link
Contributor

bader commented Apr 30, 2020

There was one commit merged by @v-klochkov recently, which I guess might impact ABI testing.
In addition to that there are a few other PRs which pass old ABI checks, which I'd like to avoid re-testing. I'm going to merge to them and update ABI checks/version after that.
@alexbatashev, I would appreciate your help with that if possible.

@alexbatashev
Copy link
Contributor Author

There was one commit merged by @v-klochkov recently, which I guess might impact ABI testing.
In addition to that there are a few other PRs which pass old ABI checks, which I'd like to avoid re-testing. I'm going to merge to them and update ABI checks/version after that.
@alexbatashev, I would appreciate your help with that if possible.

Sure, I can update the tests if they fail.

alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request May 6, 2020
…_docs

* origin/sycl: (6482 commits)
  [SYCL][NFC] Clean formatting in Markdown documents (intel#1635)
  [SYCL][Doc] Remove obsolete parens from README (intel#1637)
  [SYCL] Fix failing ABI tests when LLVM_LIBDIR_SUFFIX is set (intel#1605)
  [SYCL] Fix warnings in libdevice (intel#1630)
  [SYCL][CUDA] Triage and clean LIT (intel#1620)
  [SYCL][NFC] Fix GCC 8 compilation warnings (intel#1631)
  [SYCL] Minor fixes in LowerWGScope
  [SYCL] PI: correct default interoperability plugin selection
  [SYCL] Add faster reduction implementations using atomic or/and intel::reduce() (intel#1615)
  [SYCL] Add sycl-ls utility for listing devices discovered/selected by SYCL RT (intel#1575)
  [SYCL] Fix getDeviceFromHandler declarations (intel#1626)
  [SPIR-V] Correct/improve declaration of SPIR-V builtins (intel#1519)
  [SYCL][USM] Improve USM allocator test and fix improper behavior. (intel#1538)
  [SYCL] Fix failing ABI LITs (intel#1622)
  [SYCL] Add support for MSVC internal math functions in device library (intel#1441)
  [SYCL] Add runtime library versioning (intel#1604)
  [SYCL] Check weak symbols in ABI dumps (intel#1609)
  [NFC][SYCL] Improve kernel metadata test (intel#1610)
  Revert "[SYCL] XFAIL LIT test due to duplicate diagnostic" (intel#1460)
  [SYCL] Move the reduction command group funcs out of handler.hpp (intel#1602)
  ...
@alexbatashev alexbatashev deleted the private/abatashe/abi_check_weak_symbols branch July 28, 2021 06:44
bb-sycl pushed a commit that referenced this pull request Sep 15, 2022
This reverts commit 55d1de820841e6d9d1c6ca0cd534323d69a1cbf1.

Now that the last use of the deprecated `getPointerElementType` has
been removed, treat uses of deprecated functions as errors again.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@6811488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants