[SYCL] Add support for MSVC internal math functions in device library #1441
Conversation
jinge90
force-pushed
the
add_msvc_math_support
branch
from
2ef0c58
to
2589525
Compare
jinge90
force-pushed
the
add_msvc_math_support
branch
from
2589525
to
bad4bf2
Compare
Hi, Alexey. |
jinge90
force-pushed
the
add_msvc_math_support
branch
from
bad4bf2
to
503efc1
Compare
Signed-off-by: gejin <[email protected]>
Add cases in math_windows_test and math_fp64_windows_test for those MSVC internal functions. |
|
@bader Could you please answer? |
What is the question? |
Sorry, was looking at the old version of the page. |
| double a = NAN; | ||
| res_access[i++] = tgamma(a); | ||
| res_access[i++] = lgamma(a); | ||
| enm_access[0] = _Dtest(&a); |
There was a problem hiding this comment.
It does not look right that we reference an implementation-defined name in a test. We should instead call some standard math function that uses _Dtest (and others).
There was a problem hiding this comment.
Hi, @vzakhari
In fact, those functions are MSVC internal math functions and I think MSVC standard math functions hasn't used those functions as we only found those functions are required in MSVC std::complex implementation. In fact, if we build and run complex tests on Windows, those internal functions will be covered.
I prefer to testing all functions added to device library. Do you have any comments? @bader
Signed-off-by: gejin <[email protected]>
Signed-off-by: gejin <[email protected]>
…_docs * origin/sycl: (6482 commits) [SYCL][NFC] Clean formatting in Markdown documents (intel#1635) [SYCL][Doc] Remove obsolete parens from README (intel#1637) [SYCL] Fix failing ABI tests when LLVM_LIBDIR_SUFFIX is set (intel#1605) [SYCL] Fix warnings in libdevice (intel#1630) [SYCL][CUDA] Triage and clean LIT (intel#1620) [SYCL][NFC] Fix GCC 8 compilation warnings (intel#1631) [SYCL] Minor fixes in LowerWGScope [SYCL] PI: correct default interoperability plugin selection [SYCL] Add faster reduction implementations using atomic or/and intel::reduce() (intel#1615) [SYCL] Add sycl-ls utility for listing devices discovered/selected by SYCL RT (intel#1575) [SYCL] Fix getDeviceFromHandler declarations (intel#1626) [SPIR-V] Correct/improve declaration of SPIR-V builtins (intel#1519) [SYCL][USM] Improve USM allocator test and fix improper behavior. (intel#1538) [SYCL] Fix failing ABI LITs (intel#1622) [SYCL] Add support for MSVC internal math functions in device library (intel#1441) [SYCL] Add runtime library versioning (intel#1604) [SYCL] Check weak symbols in ABI dumps (intel#1609) [NFC][SYCL] Improve kernel metadata test (intel#1610) Revert "[SYCL] XFAIL LIT test due to duplicate diagnostic" (intel#1460) [SYCL] Move the reduction command group funcs out of handler.hpp (intel#1602) ...
Signed-off-by: gejin [email protected]
This patch is to add support for several MSVC internal functions in device libraries and the implementation of these MSVC internal functions are based on Microsoft STL: (https://github.com/microsoft/STL).