-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Do additional mostly NFC changes for reduction patch(1585) #1602
[SYCL] Do additional mostly NFC changes for reduction patch(1585) #1602
Conversation
This patch only moves he functions has been moved from handler.hpp to reduction.hpp. No any other changes done. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Vlad, please review this patch. This patch did not yet include changes for your comment: #1585 (comment) The main idea of that comment is to make the code look more graceful, in particular in finalize() method, if I understood it right. Making the handler for which parallel_for(nd_range, reduction, func) called) empty and aggregative will also require fixing some other places that now require that each command-group-function must have at least one action/task (like single_task/parallel_for/copy). The alternative to that is to change the MCGType for 'this' handler from detail::CG::KERNEL to some new type. I think this deserves a separate discussion and a patch sometime a bit later. |
Removed handler::dissociateWithHandler() Removed handler::addEventToQueue() and made queue_impl::addEvent() private again; Minor changes in comments. Replaced 'auto' with 'size_t' in couple places. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
b586eb2
to
f241d2b
Compare
Currently, there are 2 patches to simplify the review process. |
Yes, my idea was to add a new type for MCGType. |
…_docs * origin/sycl: (6482 commits) [SYCL][NFC] Clean formatting in Markdown documents (intel#1635) [SYCL][Doc] Remove obsolete parens from README (intel#1637) [SYCL] Fix failing ABI tests when LLVM_LIBDIR_SUFFIX is set (intel#1605) [SYCL] Fix warnings in libdevice (intel#1630) [SYCL][CUDA] Triage and clean LIT (intel#1620) [SYCL][NFC] Fix GCC 8 compilation warnings (intel#1631) [SYCL] Minor fixes in LowerWGScope [SYCL] PI: correct default interoperability plugin selection [SYCL] Add faster reduction implementations using atomic or/and intel::reduce() (intel#1615) [SYCL] Add sycl-ls utility for listing devices discovered/selected by SYCL RT (intel#1575) [SYCL] Fix getDeviceFromHandler declarations (intel#1626) [SPIR-V] Correct/improve declaration of SPIR-V builtins (intel#1519) [SYCL][USM] Improve USM allocator test and fix improper behavior. (intel#1538) [SYCL] Fix failing ABI LITs (intel#1622) [SYCL] Add support for MSVC internal math functions in device library (intel#1441) [SYCL] Add runtime library versioning (intel#1604) [SYCL] Check weak symbols in ABI dumps (intel#1609) [NFC][SYCL] Improve kernel metadata test (intel#1610) Revert "[SYCL] XFAIL LIT test due to duplicate diagnostic" (intel#1460) [SYCL] Move the reduction command group funcs out of handler.hpp (intel#1602) ...
for reductions from handler.hpp to reduction.hpp