Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1921 #2032

Merged
merged 4 commits into from
Mar 23, 2018
Merged

1921 #2032

merged 4 commits into from
Mar 23, 2018

Conversation

southerneer
Copy link
Contributor

@aksonov please review when you get a chance. I'm going to merge this now to get a new deploy out.

@southerneer southerneer merged commit d130501 into master Mar 23, 2018
@aksonov
Copy link
Contributor

aksonov commented Mar 26, 2018

LGTM, will you fix unit tests?

logger.log('- Location provider changed: ', provider.enabled);
logger.log('- Location provider changed: ', provider);

self.setAlwaysOn(provider.status === backgroundGeolocation.AUTHORIZATION_STATUS_ALWAYS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong one and made two new bugs - #2037, #2044 ... I will fix it

@bengtan bengtan deleted the 1921 branch May 30, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants