Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOFENCE v1: Geofence Bot Profile (Owner View) #1911

Closed
3 of 6 tasks
zavreb opened this issue Feb 26, 2018 · 13 comments
Closed
3 of 6 tasks

GEOFENCE v1: Geofence Bot Profile (Owner View) #1911

zavreb opened this issue Feb 26, 2018 · 13 comments
Assignees
Labels

Comments

@zavreb
Copy link

zavreb commented Feb 26, 2018

  • Per ticket GEOFENCE v1: Normal Bot Profile Changes (Owner View: All bots) #1895, the Edit CTA (pencil CTA) has been moved to the ellipsis.
  • Geofence bot owners automatically enable share visits so the footprint CTA should be turned on after a geofence bot is created
  • Please ensure the radius displays
  • The default cover photo for geofence bots is footprints, see Zeplin link here: zpl.io/begw5Al
  • All “guests” that have allowed shared visits can all see the visitors CTA, the number of visitors displaying should be real time.
  • If a user taps on the Visitors CTA they are taken to the Visitors screen which can be found in ticket GEOFENCE v1: Who's Here (Visitors Screen) #1897, see here for Visitors CTA UI zpl.io/a8WPlwd

image

@zavreb zavreb added this to the Sprint #5.2 | Mar 02 - Mar 15 milestone Feb 26, 2018
@zavreb
Copy link
Author

zavreb commented Mar 6, 2018

Per recent wording changes, please use the words provided on zeplin and not on the screenshots.

@aksonov
Copy link
Contributor

aksonov commented Mar 7, 2018

Does “share visits” CTA is additional to geofence property? I.e. it is possible to create geofence bot but don't share visits?

@bengtan Is it additional property for the bot? I.e. list of users who "allowed to share visits"?

@aksonov aksonov self-assigned this Mar 7, 2018
@aksonov
Copy link
Contributor

aksonov commented Mar 7, 2018

Crossposting from product-dev channel:

It looks unclear - footprint CTA looks like the button (for the owner), but he cannot press it..
Also it is not clear what should happen if the owner stops sharing his location (by disabling always on, etc.)

@aksonov
Copy link
Contributor

aksonov commented Mar 7, 2018

I need mock for unpressed "footprint" CTA.

@zavreb
Copy link
Author

zavreb commented Mar 7, 2018

Yes it is possible, users would have to tap on SKIP during the share flow and not share it with any users. (A true case would be a private bot, since for public bots, their friends could just see the public bot and enable the footprint CTA

Does “share visits” CTA is additional to geofence property? I.e. it is possible to create geofence bot but don't share visits?

See here: zpl.io/am1EBx6 for unpressed "footprint" CTA

  • Bot owner is able to untap it, but is a Guest by default after the bot is created, therefore the footprint CTA should be enabled by default

For the issue below see #1957 and #1958

Also it is not clear what should happen if the owner stops sharing his location

aksonov pushed a commit that referenced this issue Mar 8, 2018
@aksonov
Copy link
Contributor

aksonov commented Mar 9, 2018

@mstidham, @zavreb Could you please check this ticket - it doesn't communicate with the server, but UI should work

@zavreb
Copy link
Author

zavreb commented Mar 9, 2018

@aksonov LGTM. Except can't test the See Visitors/See Who's Here CTA due to server side not being ready yet.

Verified on Staging 2.1.3

aksonov pushed a commit that referenced this issue Mar 19, 2018
aksonov pushed a commit that referenced this issue Mar 19, 2018
southerneer pushed a commit that referenced this issue Mar 19, 2018
southerneer pushed a commit that referenced this issue Mar 19, 2018
southerneer pushed a commit that referenced this issue Mar 19, 2018
southerneer pushed a commit that referenced this issue Mar 19, 2018
@mstidham
Copy link

Verified on Staging Version: 2.2.0 (218)

@zavreb
Copy link
Author

zavreb commented Mar 22, 2018

Needs Rework: Cover photo changes if user disables footprint cta, however, the bot is still a geofence bot, so the cover photo should always be the footprint one. If geofence is toggled OFF, then the cover photo should go back to the non geofence one.

  • The default cover photo for geofence bots is footprints, see Zeplin link here: zpl.io/begw5Al

southerneer added a commit that referenced this issue Mar 23, 2018
@zavreb
Copy link
Author

zavreb commented Mar 24, 2018

Verified on Staging 2.3.0 🎉

@mstidham
Copy link

Verified on Staging Version: 2.3.0 (219)

@mstidham
Copy link

Verified on Production Version: 2.6.7

1 similar comment
@zavreb
Copy link
Author

zavreb commented May 18, 2018

Verified on Production Version: 2.6.7

@zavreb zavreb closed this as completed May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants