Pin to an older version of the example alpine builder #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, CI has just started failing with: ``` ERROR: failed to build: experimental features must be enabled when builder contains image extensions ``` (https://github.com/heroku/libcnb.rs/actions/runs/5530837180/jobs/10090742723?pr=592#step:10:107) This is due to the upstream images having been rebuilt with extension support, which is an experimental feature until the next stable Pack CLI release): buildpacks/samples#149 buildpacks/samples#142 As such until Pack CLI v0.30 is released as stable, we'll have to pin to an older `alpine` image by SHA256 ref. GUS-W-13746154.
schneems
approved these changes
Jul 12, 2023
edmorley
added a commit
that referenced
this pull request
Sep 7, 2023
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, in #594 the version of that builder had to be pinned to an older release, to work around a temporary incompatibility between the latest version of the builder and the latest stable Pack CLI. Now that Pack CLI 0.30 has been released, the latest alpine builder will work again.
edmorley
added a commit
that referenced
this pull request
Oct 25, 2024
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, in #594 the version of that builder had to be pinned to an older release, to work around a temporary incompatibility between the latest version of the builder and the latest stable Pack CLI. That issue has now been resolved: buildpacks/samples#170 So we can switch back to the latest image version again.
edmorley
added a commit
that referenced
this pull request
Oct 25, 2024
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, in #594 the version of that builder had to be pinned to an older release, to work around a temporary incompatibility between the latest version of the builder and the latest stable Pack CLI: buildpacks/samples#170 In addition, in #775 the image was switched to our builder image since the example images didn't use a CNB lifecycle that was compatible with Buildpack API 0.13. Both issues have since been resolved, so we can switch back to the latest version of the upstream example alpine builder, giving us musl coverage again. GUS-W-14086879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI a
pack buildis performed using one of libcnb's example CNBs and the upstreamcnb/sample-builder:alpinebuilder, in order to test that our static MUSL compile works with non-libc base images.However, CI has just started failing with:
(https://github.com/heroku/libcnb.rs/actions/runs/5530837180/jobs/10090742723?pr=592#step:10:107)
This is due to the upstream images having been rebuilt with extension support, which is an experimental feature until the next stable Pack CLI release:
buildpacks/samples#149
buildpacks/samples#142
https://github.com/buildpacks/pack/releases/tag/v0.30.0-pre3
As such until Pack CLI v0.30 is released as stable, we'll have to pin to an older
alpineimage by SHA256 ref.GUS-W-13746154.