Updates samples for run image extension #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
- When switching the run image, include the registry context (if not Docker Hub) - Verify that run image extensions are applied on top of the new run image Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
changed the base branch from
fix/override-alpine-builder
to
main
|
Please merge #142 first and the diff will be nicer |
AidanDelaney
approved these changes
Jul 10, 2023
| @@ -0,0 +1,10 @@ | |||
| # Buildpack API version | |||
| api = "0.10" | |||
There was a problem hiding this comment.
Requires #140 to update lifecycle.
|
Currently blocked on #140 |
…implify cowsay extension Signed-off-by: Natalie Arellano <[email protected]>
edmorley
added a commit
to heroku/libcnb.rs
that referenced
this pull request
Jul 12, 2023
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, CI has just started failing with: ``` ERROR: failed to build: experimental features must be enabled when builder contains image extensions ``` (https://github.com/heroku/libcnb.rs/actions/runs/5530837180/jobs/10090742723?pr=592#step:10:107) This is due to the upstream images having been rebuilt with extension support, which is an experimental feature until the next stable Pack CLI release): buildpacks/samples#149 buildpacks/samples#142 As such until Pack CLI v0.30 is released as stable, we'll have to pin to an older `alpine` image by SHA256 ref. GUS-W-13746154.
edmorley
added a commit
to heroku/libcnb.rs
that referenced
this pull request
Jul 12, 2023
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, CI has just started failing with: ``` ERROR: failed to build: experimental features must be enabled when builder contains image extensions ``` (https://github.com/heroku/libcnb.rs/actions/runs/5530837180/jobs/10090742723?pr=592#step:10:107) This is due to the upstream images having been rebuilt with extension support, which is an experimental feature until the next stable Pack CLI release): buildpacks/samples#149 buildpacks/samples#142 As such until Pack CLI v0.30 is released as stable, we'll have to pin to an older `alpine` image by SHA256 ref. GUS-W-13746154.
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
runext/update-samples
branch
from
23ac784 to
a9f0be1
Compare
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branching off of other branch as this is dependent on that fix