Fix overriding of alpine builder #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that extensions are present in alpine builder Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
fix/override-alpine-builder
branch
from
874ba80 to
2f1fcd2
Compare
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Signed-off-by: Natalie Arellano <[email protected]>
Otherwise the hello extensions buildpack will detect Signed-off-by: Natalie Arellano <[email protected]>
AidanDelaney
reviewed
Mar 1, 2023
Makefile
Outdated
| @@ -29,8 +29,6 @@ build-linux-builders: build-builder-alpine build-builder-bionic | |||
| build-builder-alpine: build-linux-packages build-sample-root | |||
| @echo "> Building 'alpine' builder..." | |||
| $(PACK_CMD) builder create cnbs/sample-builder:alpine --config $(SAMPLES_ROOT)/builders/alpine/builder.toml $(PULL_POLICY_NEVER) | |||
| docker run cnbs/sample-builder:alpine ls /cnb/extensions/samples_curl | |||
There was a problem hiding this comment.
Why are we removing these post-build checks from build-builder-alpine?
There was a problem hiding this comment.
Ah well, I guess we could keep the checks if we want - they were added previously because I was pulling the sample builder and wondering, what could possibly be going on?
Thinking about this more, the alpine builder in its current state (without --buildpack overriding the order) is actually broken 😞 for demo purposes which is not ideal. I think I will simplify the tutorial (and make the builder working by default) by introducing a BP_ environment variable to control the Hello Extensions buildpack behavior WRT extensions.
TLDR; I'll update this PR and create a corresponding docs PR to make everything better
There was a problem hiding this comment.
Added the aforementioned improvements in cc5328a and buildpacks/docs#571
…nd failed the build by default (as it requires tree, which is not installed on the builder) Now, the buildpack will opt-in to the build only if a build-time environment variable is set Additionally, it can be made to require dependencies through the environment, instead of having to edit the /bin/build script Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
commented
Mar 3, 2023
natalieparellano
commented
Mar 3, 2023
Signed-off-by: Natalie Arellano <[email protected]>
Fix alpine builder and improve extensions demo
natalieparellano
added a commit
to buildpacks/docs
that referenced
this pull request
Mar 3, 2023
…after every failed build The hello-extensions buildpack can be configured through the environment after buildpacks/samples#142 lands Signed-off-by: Natalie Arellano <[email protected]>
|
CI failing with |
natalieparellano
added a commit
that referenced
this pull request
Apr 4, 2023
…e deploying We are currently overriding the builder that was just built by using --pull-policy=always when using the builder in a build This will be fixed in #142 but we can't merge that one until the pipeline is green Signed-off-by: Natalie Arellano <[email protected]>
Merged
|
I will take a look at the circleci issue |
natalieparellano
commented
Jul 7, 2023
Signed-off-by: Natalie Arellano <[email protected]>
edmorley
added a commit
to heroku/libcnb.rs
that referenced
this pull request
Jul 12, 2023
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, CI has just started failing with: ``` ERROR: failed to build: experimental features must be enabled when builder contains image extensions ``` (https://github.com/heroku/libcnb.rs/actions/runs/5530837180/jobs/10090742723?pr=592#step:10:107) This is due to the upstream images having been rebuilt with extension support, which is an experimental feature until the next stable Pack CLI release): buildpacks/samples#149 buildpacks/samples#142 As such until Pack CLI v0.30 is released as stable, we'll have to pin to an older `alpine` image by SHA256 ref. GUS-W-13746154.
edmorley
added a commit
to heroku/libcnb.rs
that referenced
this pull request
Jul 12, 2023
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, CI has just started failing with: ``` ERROR: failed to build: experimental features must be enabled when builder contains image extensions ``` (https://github.com/heroku/libcnb.rs/actions/runs/5530837180/jobs/10090742723?pr=592#step:10:107) This is due to the upstream images having been rebuilt with extension support, which is an experimental feature until the next stable Pack CLI release): buildpacks/samples#149 buildpacks/samples#142 As such until Pack CLI v0.30 is released as stable, we'll have to pin to an older `alpine` image by SHA256 ref. GUS-W-13746154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need --pull-policy=always when the builder contains extensions (the builder must exist in a registry so that we can pull the manifest)
However pulling the remote builder overrides the locally built one, making our test useless and causing us to re-publish the builder that was already in Docker Hub
Spinning up a local registry should solve the problem