Switch back to the example alpine builder in CI #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on buildpacks/samples#170 |
edmorley
force-pushed
the
edmorley/ci-alpine-latest
branch
2 times, most recently
from
2e0c776 to
14d5115
Compare
edmorley
force-pushed
the
edmorley/ci-alpine-latest
branch
from
14d5115 to
7b1136a
Compare
edmorley
force-pushed
the
edmorley/ci-alpine-latest
branch
from
7b1136a to
25e1e5e
Compare
edmorley
force-pushed
the
edmorley/ci-alpine-latest
branch
from
25e1e5e to
c816b59
Compare
|
I'm happy to close this for now; we have the TODO in the workflow file, plus I'm still subscribed to the upstream issue in their examples repo. |
edmorley
force-pushed
the
edmorley/ci-alpine-latest
branch
from
c816b59 to
e6c24b3
Compare
edmorley
changed the title
In CI a `pack build` is performed using one of libcnb's example CNBs and the upstream `cnb/sample-builder:alpine` builder, in order to test that our static MUSL compile works with non-libc base images. However, in #594 the version of that builder had to be pinned to an older release, to work around a temporary incompatibility between the latest version of the builder and the latest stable Pack CLI: buildpacks/samples#170 In addition, in #775 the image was switched to our builder image since the example images didn't use a CNB lifecycle that was compatible with Buildpack API 0.13. Both issues have since been resolved, so we can switch back to the latest version of the upstream example alpine builder, giving us musl coverage again. GUS-W-14086879.
edmorley
force-pushed
the
edmorley/ci-alpine-latest
branch
from
e6c24b3 to
d2bc86f
Compare
Malax
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI a
pack buildis performed using one of libcnb's example CNBs and the upstreamcnb/sample-builder:alpinebuilder, in order to test that our static MUSL compile works with non-libc base images.However, in #594 the version of that builder had to be pinned to an older release, to work around a temporary incompatibility between the latest version of the builder and the latest stable Pack CLI:
buildpacks/samples#170
In addition, in #775 the image was switched to our builder image since the example images didn't use a CNB lifecycle that was compatible with Buildpack API 0.13.
Both issues have since been resolved, so we can switch back to the latest version of the upstream example alpine builder, giving us musl coverage again.
GUS-W-14086879.