frontend: PluginSettings: Use author for plugin origin #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
skoeva
force-pushed
the
plugin-name-formats
branch
from
9e7c439
to
761dfb8
Compare
dosubot
bot
added
size:XL
skoeva
force-pushed
the
plugin-name-formats
branch
from
761dfb8
to
95d150f
Compare
dosubot
bot
added
size:L
skoeva
force-pushed
the
plugin-name-formats
branch
5 times, most recently
from
f6598ee
to
35ba0fc
Compare
|
Can you please split the commits to changes in separate components out? |
|
I wonder if we can use the fit repo if it’s there instead of unknown? Just a thought, I don’t think adding the GitHub repo should be done in this PR. We should however make sure all our plugins have the author in the package.json (Also separate to this PR) |
joaquimrocha
previously requested changes
Nov 21, 2024
frontend/src/components/App/PluginSettings/PluginSettingsDetails.tsx
Outdated
Show resolved
Hide resolved
skoeva
force-pushed
the
plugin-name-formats
branch
from
35ba0fc
to
0bf951b
Compare
This change makes the formatting of the plugin names consistent, using the plugin author for the origin value. When the author is not set, the default origin is "Unknown". Fixes: #2544 Signed-off-by: Evangelos Skopelitis <[email protected]>
Signed-off-by: Evangelos Skopelitis <[email protected]>
skoeva
force-pushed
the
plugin-name-formats
branch
from
0bf951b
to
97131b9
Compare
|
@illume added a separate commit for the subtitle change, lmk if this should be split up further to reflect the change itself vs the context it's being used in |
skoeva
added a commit
that referenced
this pull request
Nov 22, 2024
This change addresses a regression introduced by #2572 since the SectionHeader components were aligned in a column, causing title side actions to appear under the title. Now, subtitles should appear under the title, and title side actions should appear next to the title. Fixes: #2605 Signed-off-by: Evangelos Skopelitis <[email protected]>
4 tasks
skoeva
added a commit
that referenced
this pull request
Nov 27, 2024
This change addresses a regression introduced by #2572 since the SectionHeader components were aligned in a column, causing title side actions to appear under the title. Now, subtitles should appear under the title, and title side actions should appear next to the title. Fixes: #2605 Signed-off-by: Evangelos Skopelitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the formatting of the plugin names consistent, using the plugin author for the origin value. When the author is not set, the default origin is "Unknown".
Fixes: #2544
Testing